From owner-cvs-src@FreeBSD.ORG Tue Jul 26 17:02:33 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B97CC16A41F; Tue, 26 Jul 2005 17:02:33 +0000 (GMT) (envelope-from peter@wemm.org) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6447E43D48; Tue, 26 Jul 2005 17:02:33 +0000 (GMT) (envelope-from peter@wemm.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id 48B2C2A8FB; Tue, 26 Jul 2005 10:02:33 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id F1896E2B5; Tue, 26 Jul 2005 10:02:32 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (8.13.4/8.13.1) with ESMTP id j6QH2W5Y091951; Tue, 26 Jul 2005 10:02:32 -0700 (PDT) (envelope-from peter@wemm.org) Received: from localhost (localhost [[UNIX: localhost]]) by overcee.wemm.org (8.13.4/8.13.1/Submit) id j6QH2V7e091950; Tue, 26 Jul 2005 10:02:31 -0700 (PDT) (envelope-from peter@wemm.org) X-Authentication-Warning: overcee.wemm.org: peter set sender to peter@wemm.org using -f From: Peter Wemm To: "Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=" Date: Tue, 26 Jul 2005 10:02:30 -0700 User-Agent: KMail/1.8.1 References: <200507141952.j6EJqMVQ009846@repoman.freebsd.org> <86oe8phlq1.fsf@xps.des.no> In-Reply-To: <86oe8phlq1.fsf@xps.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200507261002.31596.peter@wemm.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Jung-uk Kim Subject: Re: cvs commit: src/sys/boot/i386/libi386 Makefile libi386.h smbios.c src/sys/boot/i386/loader main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2005 17:02:33 -0000 On Tuesday 26 July 2005 04:04 am, Dag-Erling Sm=F8rgrav wrote: > Jung-uk Kim writes: > > Log: > > Scan static SMBIOS structures and export the following > > environment variables to loader: [...] > > These values are sometimes padded, IWBNI libi386 could remove that > padding: > > hint.smbios.0.system.maker=3D"Dell Inc. " > hint.smbios.0.system.product=3D"Dimension XPS Gen 3 " > > also, there's a typo in one of the strings: > > Hint.smbios.0.planar.version=3D" " > > (note the capital H) It's not a typo. Its got the wrong number of fields so the hint scanner=20 disables it. if (strncmp(cp, "hint.", 5) !=3D 0) hit =3D 0; else n =3D sscanf(cp, "hint.%32[^.].%d.%32[^=3D]=3D%128s= ", r_name, &r_unit, r_resname, r_value); if (hit && n !=3D 4) { printf("CONFIG: invalid hint '%s'\n", cp); p =3D index(cp, 'h'); *p =3D 'H'; hit =3D 0; } hint.smbios.0.planar.version is an illegal hint. It has 5 fields, not=20 4. These are not free-form strings. =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5