From owner-freebsd-net@FreeBSD.ORG  Thu May 20 10:30:14 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0975316A4CE
	for <freebsd-net@freebsd.org>; Thu, 20 May 2004 10:30:14 -0700 (PDT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B3D0243D46
	for <freebsd-net@freebsd.org>; Thu, 20 May 2004 10:30:13 -0700 (PDT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 52698ACAE0; Thu, 20 May 2004 19:30:12 +0200 (CEST)
Date: Thu, 20 May 2004 19:30:12 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: freebsd-net@freebsd.org
Message-ID: <20040520173012.GR845@darkness.comp.waw.pl>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="QUQ5hgLY738rkNmy"
Content-Disposition: inline
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
Subject: Socket selection.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 May 2004 17:30:14 -0000


--QUQ5hgLY738rkNmy
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

In in_pcblookup_hash() function, in the last loop if we find exact
match, we return immediately, if it is "wild", we store a pointer and
we countinue looking for exact match.
I wonder if this is ok, that we change pointer every time we find a
"wild" match. Is it inteded? Shouldn't it be:

	http://people.freebsd.org/~pjd/patches/in_pcb.c.2.patch

?

While I'm here, I want to improve code readability a bit:

	http://people.freebsd.org/~pjd/patches/in_pcb.c.3.patch

Is it ok?

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--QUQ5hgLY738rkNmy
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFArOskForvXbEpPzQRAuqYAJsEGP+3IZc3Iisjnnd5/gsPirjNlQCg99KE
P07Vse12bNaTjw38fQHeQJs=
=nweI
-----END PGP SIGNATURE-----

--QUQ5hgLY738rkNmy--