From owner-freebsd-current@FreeBSD.ORG  Tue Aug 18 13:11:10 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C9CC106564A
	for <freebsd-current@freebsd.org>; Tue, 18 Aug 2009 13:11:10 +0000 (UTC)
	(envelope-from ota@j.email.ne.jp)
Received: from mail2.asahi-net.or.jp (mail2.asahi-net.or.jp [202.224.39.198])
	by mx1.freebsd.org (Postfix) with ESMTP id 6FF9B8FC55
	for <freebsd-current@freebsd.org>; Tue, 18 Aug 2009 13:11:10 +0000 (UTC)
Received: from localhost (pool-70-20-219-14.phil.east.verizon.net
	[70.20.219.14])
	by mail2.asahi-net.or.jp (Postfix) with ESMTP id E625480293;
	Tue, 18 Aug 2009 22:11:07 +0900 (JST)
Date: Tue, 18 Aug 2009 09:11:04 -0400
From: Yoshihiro Ota <ota@j.email.ne.jp>
To: Hans Petter Selasky <hselasky@c2i.net>
Message-Id: <20090818091104.28cda3be.ota@j.email.ne.jp>
In-Reply-To: <200908180706.30202.hselasky@c2i.net>
References: <20090213204112.7b982402.ota@j.email.ne.jp>
	<20090214133457.e47df9b5.ota@j.email.ne.jp>
	<20090817225105.88fa579d.ota@j.email.ne.jp>
	<200908180706.30202.hselasky@c2i.net>
X-Mailer: Sylpheed 2.6.0 (GTK+ 2.12.11; i386-portbld-freebsd7.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: USB2 - keyboard error
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2009 13:11:10 -0000

On Tue, 18 Aug 2009 07:06:29 +0200
Hans Petter Selasky <hselasky@c2i.net> wrote:

> On Tuesday 18 August 2009 04:51:05 Yoshihiro Ota wrote:
> > Hi all and Hans,
> >
> > After switching code base for 8 release, I realized problems with my
> > keyboard. The work-around described below fixed my problems.
> >
> > Could you be able to incorporate fix for this?
> >
> > Thanks,
> > Hiro
> 
> Can you resend the patch?
> 
> --HPS

Below is the change you suggested.
It doesn't look good for other keyboards.

Thanks,
Hiro

%env LANG=C svn diff --diff-cmd /usr/bin/diff -x-U10 input/ukbd.c
Index: input/ukbd.c
===================================================================
--- input/ukbd.c        (revision 196086)
+++ input/ukbd.c        (working copy)
@@ -606,20 +606,21 @@
 }
 
 static void
 ukbd_set_leds_callback(struct usb_xfer *xfer, usb_error_t error)
 {
        struct usb_device_request req;
        struct usb_page_cache *pc;
        uint8_t buf[2];
        struct ukbd_softc *sc = usbd_xfer_softc(xfer);
 
+return; /* USB-keyboard workaround */
        switch (USB_GET_STATE(xfer)) {
        case USB_ST_TRANSFERRED:
        case USB_ST_SETUP:
                if (sc->sc_flags & UKBD_FLAG_SET_LEDS) {
                        sc->sc_flags &= ~UKBD_FLAG_SET_LEDS;
 
                        req.bmRequestType = UT_WRITE_CLASS_INTERFACE;
                        req.bRequest = UR_SET_REPORT;
                        USETW2(req.wValue, UHID_OUTPUT_REPORT, 0);
                        req.wIndex[0] = sc->sc_iface_no;