From owner-svn-src-all@freebsd.org Fri Oct 23 14:25:54 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7FDAA1D6E9 for ; Fri, 23 Oct 2015 14:25:54 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 83641155B for ; Fri, 23 Oct 2015 14:25:54 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 23 Oct 2015 14:26:07 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t9NEPpNb021237; Fri, 23 Oct 2015 08:25:51 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1445610351.91534.1.camel@freebsd.org> Subject: Re: svn commit: r289778 - head/share/mk From: Ian Lepore To: Bryan Drewery Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Fri, 23 Oct 2015 08:25:51 -0600 In-Reply-To: <6847681E-3E85-40B9-BF9D-2FF4C6DE4AC9@FreeBSD.org> References: <201510222341.t9MNfuNK007465@repo.freebsd.org> <1445558386.14963.38.camel@freebsd.org> <232D9171-D360-4110-8682-6B371D9F9CAC@FreeBSD.org> <6847681E-3E85-40B9-BF9D-2FF4C6DE4AC9@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 14:25:54 -0000 On Thu, 2015-10-22 at 17:21 -0700, Bryan Drewery wrote: > > On Oct 22, 2015, at 17:18, Bryan Drewery > > wrote: > > > > > > > > > > On Oct 22, 2015, at 16:59, Ian Lepore wrote: > > > > > > > > On Thu, 2015-10-22 at 23:41 +0000, Bryan Drewery wrote: > > > > Author: bdrewery > > > > Date: Thu Oct 22 23:41:56 2015 > > > > New Revision: 289778 > > > > URL: https://svnweb.freebsd.org/changeset/base/289778 > > > > > > > > Log: > > > > For SUBDIR_PARALLEL, when doing 'make clean*' or 'make obj' > > > > there > > > > is no need to > > > > respect SUBDIR_DEPEND_* or .WAIT. > > > > > > > > MFC after: 2 weeks > > > > Sponsored by: EMC / Isilon Storage Division > > > > > > This doesn't feel so safe. People override these targets and do > > > who > > > -knows-what with them. The clean* seems especially risky since > > > it will > > > match targets in end-user makefiles that you don't even know > > > about. > > I can also not apply to SUBDIR_TARGETS which is the user-defined > targets list. (Misspelled and should be LOCAL_SUBDIR_TARGETS) > That might be a good idea. When I grepped our devel/mk directory, SUBDIR_TARGETS was where I saw a number of things that would match clean* (I didn't look into exactly what they do). -- Ian > > > > > > -- Ian > > > > I can limit it to src tree builds if you want. > > > > I cannot imagine any situation where "clean" depends on > > another directory going first. > > > > Similarly it makes sense to always build subdirs in parallel with > > 'obj' and I would argue 'clean*' too, regardless of > > SUBDIR_PARALLEL. I only just realized that. Yes there are mkdir -p > > and rm -f races, but we have not added any dependencies because of > > these as is. > >