From owner-freebsd-current Sun Feb 16 22:30:48 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0462E37B405 for ; Sun, 16 Feb 2003 22:30:46 -0800 (PST) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78A9543FCB for ; Sun, 16 Feb 2003 22:30:44 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.6/8.12.6) with ESMTP id h1H6Ug6E051543; Mon, 17 Feb 2003 06:30:42 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h1H6UfOx095189; Mon, 17 Feb 2003 07:30:42 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: Marcel Moolenaar Cc: current@FreeBSD.ORG Subject: Re: Console API related patch. From: phk@phk.freebsd.dk In-Reply-To: Your message of "Sun, 16 Feb 2003 16:04:10 PST." <20030217000410.GA769@dhcp01.pn.xcllnt.net> Date: Mon, 17 Feb 2003 07:30:41 +0100 Message-ID: <95188.1045463441@critter.freebsd.dk> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030217000410.GA769@dhcp01.pn.xcllnt.net>, Marcel Moolenaar writes: >> This patch changes the API so that rather than pass a "dev_t" to the >> console functions, the "struct consdev *" is passed: >> >> -typedef void cn_putc_t(dev_t, int); >> +typedef void cn_putc_t(struct consdev *, int); >> > >I like this. On the ia64 branch I completely ignore the dev argument >and instead use a static softc. The dev_t is unknown until after >bus enumeration in principle anyway. Yeah, I saw that. Actually I think more or less any console driver which uses the dev_t arg is wrong about doing that, but we can fix that subsequently. >I'll test ia64, both CVS an P4. Let me know when you like to >commit this so that I can schedule around that... I'm no no particular hurry, so whenever I have sufficient feedback to convince me that its safe. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message