From owner-freebsd-java@FreeBSD.ORG Fri Oct 8 02:40:49 2004 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3A8B16A4CE; Fri, 8 Oct 2004 02:40:49 +0000 (GMT) Received: from gldis.ca (constans.gldis.ca [66.11.169.73]) by mx1.FreeBSD.org (Postfix) with ESMTP id 603EA43D53; Fri, 8 Oct 2004 02:40:49 +0000 (GMT) (envelope-from gldisater@gldis.ca) Received: from [127.0.0.1] (localhost [127.0.0.1]) by gldis.ca (8.12.11/8.12.11) with ESMTP id i982mYrn038080; Thu, 7 Oct 2004 22:48:35 -0400 (EDT) (envelope-from gldisater@gldis.ca) From: Jeremy Faulkner To: Herve Quiroz In-Reply-To: <20041007135046.GA99606@arabica.esil.univ-mrs.fr> References: <1097094403.90638.7.camel@ocean-deep.gldis.ca> <20041007135046.GA99606@arabica.esil.univ-mrs.fr> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JQ9knkFrTdmK4XBFyitP" Message-Id: <1097189014.37262.15.camel@ocean-deep.gldis.ca> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 07 Oct 2004 22:43:35 +0000 X-Virus-Scanned: ClamAV version 'clamd / ClamAV version 0.65', clamav-milter version '0.60p' cc: java@freebsd.org Subject: Re: Azureus port skeleton for testing X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2004 02:40:50 -0000 --=-JQ9knkFrTdmK4XBFyitP Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2004-10-07 at 13:50, Herve Quiroz wrote: > First, the Makefile itself: >=20 > - A quick portlint give me the following output: >=20 > WARN: Makefile: "EXTRACT_ONLY" has to appear earlier. > WARN: Makefile: "DISTFILES" has to appear earlier. > WARN: Makefile: "EXTRACT_ONLY" has to appear earlier. > 0 fatal errors and 3 warnings found. portlint and I have never gotten along well together, until now. > - It is generally not a good idea to install JAR files in ${PREFIX}/bin. > As suggested in [1], a Java application should install its data files > (such as its JAR files) in an overriden ${DATADIR} which is set to > ${JAVASHAREDIR}/${PORTNAME}. Ok. > Second, looking at your shell script in files/, there are some things > you may improve: >=20 > - Too many paths are hardcoded. You may use %%PREFIX%% for instance and > perform some sed magic in 'do-configure' target. Don't forget to > differenciate ${PREFIX} (for everything related to the current port) > and ${LOCALBASE} (for everything else, such as Eclipse stuff). >=20 > - The same goes for the path of the 'java' executable. You could rather > use the same kind of sed magic to replace %%JAVA%% with ${JAVA}. >=20 Yes, I know there are a lot of hard coded values in the script, I even said as much in my email to the list. The new version of the port that I just uploaded (10:30 EST Thursday) should be better, and should allow the use of the motif SWT. I'll test the motif SWT during the weekend. > That said, this is just a quick review as I don't have enough time ATM. > If nobody else handles this port by the next days, I will probably > handle this myself. In such a case, you may send a PR and CC me. We're > still under ports CVS tree freeze ATM, so there's no hurry here. >=20 > Herve I'll create the PR when I'm satisfied with the port. I think the currently available version is Pretty Damn Close To Done (TM). --=20 Jeremy Faulkner --=-JQ9knkFrTdmK4XBFyitP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBZcaWfb0Lle2MIEIRAjfjAJ9L3/rh6btKi7a0hfoEEoNneWGfbACeOCih A+IgUOHq8y2MFugYrPs+QUk= =5RiG -----END PGP SIGNATURE----- --=-JQ9knkFrTdmK4XBFyitP--