From owner-svn-src-all@FreeBSD.ORG  Sat May 17 02:26:57 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4D7B7DE6;
 Sat, 17 May 2014 02:26:57 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 0E17B2155;
 Sat, 17 May 2014 02:26:56 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id DDECDA968;
 Sat, 17 May 2014 02:26:48 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id B24E53029B; Sat, 17 May 2014 04:26:51 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r266238 - head/contrib/ldns/ldns
References: <201405161532.s4GFWGvh006504@svn.freebsd.org>
 <20140517112645.N925@besplex.bde.org>
Date: Sat, 17 May 2014 04:26:51 +0200
In-Reply-To: <20140517112645.N925@besplex.bde.org> (Bruce Evans's message of
 "Sat, 17 May 2014 11:46:16 +1000 (EST)")
Message-ID: <86ppjdjg2c.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 May 2014 02:26:57 -0000

Bruce Evans <brde@optusnet.com.au> writes:
> -Wcast-qual is especially onerous in contrib'ed code written to a lower
> standard.

Well, I could have just lowered WARNS...  LDNS actually isn't that bad.
Unbound is much worse.

> Converting this to use system endianness conversion functions wouldn't
> take much more churn.

Do our standard endianness conversion functions handle unaligned
accesses?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no