From owner-freebsd-current@FreeBSD.ORG Tue Nov 15 18:15:04 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28F801065670; Tue, 15 Nov 2011 18:15:04 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 13AB68FC17; Tue, 15 Nov 2011 18:15:02 +0000 (UTC) Received: by faar19 with SMTP id r19so1020482faa.13 for ; Tue, 15 Nov 2011 10:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=O+QPNLAEJ4A4tuasufnM1wdPbX/3AyuzfVaXEDXO3os=; b=snD6Nl2HBOAZh9PH84Zh9FDzuzrAOnedMtd9KfYPqT+AI75rk9+loL+HYXph2fGmBd S/Fqub5yA8M2Dwny8LRz3/4dP97hwoO1E1vEoRAcF6WVNUk/CfCPIRFpxOM9Op7NFTD4 bO6YqOrf/EL4iG6SlKLG1HNqFQ52477F4uy/k= MIME-Version: 1.0 Received: by 10.152.105.226 with SMTP id gp2mr17767509lab.28.1321380901158; Tue, 15 Nov 2011 10:15:01 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.152.21.104 with HTTP; Tue, 15 Nov 2011 10:15:01 -0800 (PST) In-Reply-To: <20111107193516.GA50300@deviant.kiev.zoral.com.ua> References: <4EB40015.5040100@rice.edu> <20111104153004.GK50300@deviant.kiev.zoral.com.ua> <4EB4095D.3030303@rice.edu> <20111104160339.GM50300@deviant.kiev.zoral.com.ua> <20111105141306.GW50300@deviant.kiev.zoral.com.ua> <20111105151530.GX50300@deviant.kiev.zoral.com.ua> <4EB595FA.4020500@rice.edu> <20111106124331.GP50300@deviant.kiev.zoral.com.ua> <4EB81942.70501@rice.edu> <20111107193516.GA50300@deviant.kiev.zoral.com.ua> Date: Tue, 15 Nov 2011 19:15:01 +0100 X-Google-Sender-Auth: ooZX_iQmKFguhgChWmyjOkvOg8E Message-ID: From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: mdf@freebsd.org, "K. Macy" , Alan Cox , Andriy Gapon , freebsd-current@freebsd.org, Benjamin Kaduk , Penta Upa Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2011 18:15:04 -0000 2011/11/7 Kostik Belousov : > On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: >> Ok. =C2=A0I'll offer one final suggestion. =C2=A0Please consider an alte= rnative >> suffix to "func". =C2=A0Perhaps, "kbi" or "KBI". =C2=A0In other words, s= omething >> that hints at the function's reason for existing. > > Sure. Below is the extraction of only vm_page_lock() bits, together > with the suggested rename. When Attilio provides the promised simplificat= ion > of the mutex KPI, this can be reduced. My tentative patch is here: http://www.freebsd.org/~attilio/mutexfileline.patch I need to make more compile testing later, but it already compiles GENERIC + modules fine on HEAD. The patch provides a common entrypoint, option independent, for both fast case and debug/compat case. Additively, it almost entirely fixes the standard violation of the reserved namespace, as you described (the notable exception being the macro used in the fast path, that I want to fix as well, but in a separate commit). Now the file/line couplet can be passed to the "_" suffix variant of the flag functions. eadler@ reviewed the mutex.h comment. Please let me know what you think about it, as long as we agree on the patch I'll commit it. Attilio --=20 Peace can only be achieved by understanding - A. Einstein