From owner-freebsd-current Sun Feb 16 22:30:49 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6AF237B401; Sun, 16 Feb 2003 22:30:47 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19E2043F3F; Sun, 16 Feb 2003 22:30:47 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id h1H6Uk3Y027219; Sun, 16 Feb 2003 23:30:46 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 16 Feb 2003 23:30:05 -0700 (MST) Message-Id: <20030216.233005.69986720.imp@bsdimp.com> To: nate@root.org Cc: current@FreeBSD.ORG, wpaul@FreeBSD.ORG Subject: Re: sys/pci/if* fixes From: "M. Warner Losh" In-Reply-To: References: X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG One thing: you don't need to move the allocation of the interrupt, just the turning it on. However, if you move the location that you turn it on be careful that the driver doesn't do something silly in its attach routine. I was wrong a while ago when I said that the attach routines typically turned on the interrupts in the card. That's usually done in the the if_init() routine that the driver registers. So the advise about doing the enabling of interrupts last in the attach routine should be considered bogus. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message