From owner-freebsd-bugs@freebsd.org  Sat Jul 30 17:54:39 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DB39BA86F9
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sat, 30 Jul 2016 17:54:39 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D34C1713
 for <freebsd-bugs@FreeBSD.org>; Sat, 30 Jul 2016 17:54:39 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6UHsdbq016361
 for <freebsd-bugs@FreeBSD.org>; Sat, 30 Jul 2016 17:54:39 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 204602] parse() in boot loader interp_parse.c is too naive
 about quotes
Date: Sat, 30 Jul 2016 17:54:39 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: commit-hook@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-204602-8-bnMZu4Z1CF@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204602-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-204602-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2016 17:54:39 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204602

--- Comment #1 from commit-hook@freebsd.org ---
A commit references this bug:

Author: allanjude
Date: Sat Jul 30 17:53:37 UTC 2016
New revision: 303556
URL: https://svnweb.freebsd.org/changeset/base/303556

Log:
  Improve boot loader quote parsing

  parse() is the boot loader's interp_parse.c is too naive about quotes

  both single and double quotes were allowed to be mixed, and single
  quotes did not follow the usual semantics (re variable expansion).

  The old code did not check for terminating quotes

  This update implements:
   * distinguishing single and double quote
   * variable expansion will not be done inside single quote protected area
   * will preserve inner quote for values like "value 'some list'"
   * ending quote check.

  this diff does not implement ending quote order check, it shouldn't
  be too hard, needs some improvements on parser state machine.

  PR:           204602
  Submitted by: Toomas Soome <tsoome@me.com>
  Relnotes:     yes
  Differential Revision:        https://reviews.freebsd.org/D6000

Changes:
  head/sys/boot/common/interp_parse.c

--=20
You are receiving this mail because:
You are the assignee for the bug.=