From owner-svn-ports-all@FreeBSD.ORG Sat Apr 27 08:13:39 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7BBABE3E; Sat, 27 Apr 2013 08:13:39 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-x230.google.com (mail-ea0-x230.google.com [IPv6:2a00:1450:4013:c01::230]) by mx1.freebsd.org (Postfix) with ESMTP id 887AF125D; Sat, 27 Apr 2013 08:13:38 +0000 (UTC) Received: by mail-ea0-f176.google.com with SMTP id h14so1993155eak.35 for ; Sat, 27 Apr 2013 01:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=y+euObU3gEN50V8rT4q6WBeouVoyZDykHwop1UPf87E=; b=c8BwrJeexk8wQdX7VVNOXb5sO/M8EVnaxITLJv7wF+/qIN79sHcYuHnktzw7AgECo5 VoMSc6AxGRRObs0A+zsnrxc70IE9CPpzzOoGsHMpJvRYnQyU7zM/v8DNKoxQNJ18Nw/P SEkgdQlO+xzm4eHG+2HBeTy9ZJqIXz9w4NbSoTT6/xrZDrxbAXYTqRlqurmm3S+0CZlC FhO41VlERBWaVXBytrOiCCzq4dMJojxLBRr6v/en0ptl9BMxDb/rIwNgFuJ1Mqu/qVA5 /iYBimkxnL7h5yPpRmAKu8fRH8ifAVUJpEshiNXwZ6Qo2eWaAjTgO52q55tPXlc8Ck2A 5JNA== X-Received: by 10.15.77.133 with SMTP id p5mr51929508eey.46.1367050417589; Sat, 27 Apr 2013 01:13:37 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id cd3sm20457163eeb.6.2013.04.27.01.13.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 27 Apr 2013 01:13:36 -0700 (PDT) Sender: Baptiste Daroussin Date: Sat, 27 Apr 2013 10:13:34 +0200 From: Baptiste Daroussin To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r316281 - head/Mk Message-ID: <20130427081334.GI74139@ithaqua.etoilebsd.net> References: <201304222213.r3MMDFec026886@svn.freebsd.org> <20130426201532.GE74139@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yzvKDKJiLNESc64M" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Apr 2013 08:13:39 -0000 --yzvKDKJiLNESc64M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2013 at 12:36:47PM +0800, Sunpoet Po-Chuan Hsieh wrote: > On Sat, Apr 27, 2013 at 4:15 AM, Baptiste Daroussin wro= te: >=20 > > On Sat, Apr 27, 2013 at 03:48:01AM +0800, Sunpoet Po-Chuan Hsieh wrote: > > > On Tue, Apr 23, 2013 at 6:13 AM, Baptiste Daroussin > >wrote: > > > > > > > Author: bapt > > > > Date: Mon Apr 22 22:13:14 2013 > > > > New Revision: 316281 > > > > URL: http://svnweb.freebsd.org/changeset/ports/316281 > > > > > > > > Log: > > > > Remove old links while creating the new packages > > > > Force creation of the symlink for pkgng to avoid failure if the l= ink > > > > already exists > > > > > > > > Submitted by: ohauer@ > > > > > > > > Modified: > > > > head/Mk/bsd.pkgng.mk > > > > > > > > Modified: head/Mk/bsd.pkgng.mk > > > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > > --- head/Mk/bsd.pkgng.mk Mon Apr 22 22:06:34 2013 > > (r316280) > > > > +++ head/Mk/bsd.pkgng.mk Mon Apr 22 22:13:14 2013 > > (r316281) > > > > @@ -258,6 +258,9 @@ do-package: ${TMPPLIST} > > > > fi; \ > > > > fi; \ > > > > fi; > > > > + @for cat in ${CATEGORIES}; do \ > > > > + ${RM} -fv > > > > ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \ > > > > + done > > > > > > > > > > Please revert/modify this change! > > > It has 2 problems. > > > > > > First, it would remove other *correct* links. > > > > > > % cd /usr/ports/x11/xorg > > > % make package > > > ... > > > =3D=3D=3D> Checking if x11/xorg already installed > > > =3D=3D=3D> Registering installation for xorg-7.5.2 > > > Installing xorg-7.5.2... done > > > =3D=3D=3D> Building package for xorg-7.5.2 > > > /usr/ports/packages/x11/xorg-7.5.2.txz > > > /usr/ports/packages/x11/xorg-cf-files-1.0.4.txz > > > /usr/ports/packages/x11/xorg-libraries-7.5.1.txz > > > /usr/ports/packages/x11/xorg-macros-1.16.1.txz > > > Creating package for xorg-7.5.2 > > > > This is not the problem but the goal with pkgng we need no more links > > anywhere > > except for pkgng itseld because the bootstrap in base relies on it. >=20 >=20 > Does that mean all links in $CATEGORIES directories are unnecessary? If s= o, > could we simply remove those directories instead of individual links? >=20 Yes All CATEGORIES symlinks are unecessary now, so does all symlinks in Lat= est (except pkg.txz) I'm open to better solutions to clean that that the one we have now :) regards, Bapt --yzvKDKJiLNESc64M Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlF7iK4ACgkQ8kTtMUmk6EyyGQCglyIQmXlpagjD37MWVC6T7Nyi ZYgAn1JVI+PnM9O3jAX63yMMi1Li/OzA =PQvU -----END PGP SIGNATURE----- --yzvKDKJiLNESc64M--