From owner-freebsd-current Tue Apr 2 13:18:09 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id NAA27059 for current-outgoing; Tue, 2 Apr 1996 13:18:09 -0800 (PST) Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id NAA27054 for ; Tue, 2 Apr 1996 13:18:07 -0800 (PST) Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id OAA17134; Tue, 2 Apr 1996 14:12:29 -0700 From: Terry Lambert Message-Id: <199604022112.OAA17134@phaeton.artisoft.com> Subject: Re: Fixit Floppy Broken? To: count@key.hole.fi (Bror 'Count' Heinola) Date: Tue, 2 Apr 1996 14:12:29 -0700 (MST) Cc: joerg_wunsch@uriah.heep.sax.de, freebsd-current@FreeBSD.ORG In-Reply-To: <199604020813.LAA04262@key.hole.fi> from "Bror 'Count' Heinola" at Apr 2, 96 11:13:27 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > Filing a PR won't help very much. The floppy driver is in bad need > > for a rewrite. > > > > If you're willing to rewrite it, and submitting PRs would accelerate > > this process, i could immediately submit half a dozen PRs for it. :-) > > Hey, couldn't 'we' use the magnificent dancing and whistling > fd driver made by Jesus Monroy Jr. ? :-) >From what I could tell looking at it, it was decent code. He had one bad bug... and it seemed to be more of an architectural ordering bug (he wanted to do something one way, and the controller manufactureres wanted him to reverse the logic for it to work). Changing the ordering would have required a timeout in order to retry to eliminate a race window. But the code did not suck, even if many of his ideas were off the wall. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.