From owner-svn-ports-head@FreeBSD.ORG Sat Jun 15 09:06:09 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6DD8B80F; Sat, 15 Jun 2013 09:06:09 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward5l.mail.yandex.net (forward5l.mail.yandex.net [IPv6:2a02:6b8:0:1819::5]) by mx1.freebsd.org (Postfix) with ESMTP id 321371EA2; Sat, 15 Jun 2013 09:06:09 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward5l.mail.yandex.net (Yandex) with ESMTP id 8C408C40CFC; Sat, 15 Jun 2013 13:06:07 +0400 (MSK) Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id F1B677E07C7; Sat, 15 Jun 2013 13:06:06 +0400 (MSK) Received: from 78.108.206.107.tel.ru (78.108.206.107.tel.ru [78.108.206.107]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Fs3R5Ujbhb-66WqRYIa; Sat, 15 Jun 2013 13:06:06 +0400 Message-ID: <51BC2E7E.8030605@passap.ru> Date: Sat, 15 Jun 2013 13:06:06 +0400 From: Boris Samorodov Organization: =?UTF-8?B?0JfQkNCeICLQktCQ0KDQoiI=?= User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:17.0) Gecko/20130517 Thunderbird/17.0.6 MIME-Version: 1.0 To: bapt Subject: Re: RE : Re: svn commit: r320973 - head/audio/grip References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , bapt , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2013 09:06:09 -0000 (email reformatted) 15.06.2013 12:35, bapt пишет: > Envoyé depuis mon mobile OrangeBoris Samorodov a écrit : 15.06.2013 02:31, Baptiste Daroussin пишет: > >> Log: >> Use new options helpers >> >> Modified: >> head/audio/grip/Makefile >> > [...] >> LIB_DEPENDS= id3-3.8.3:${PORTSDIR}/audio/id3lib \ >> - curl.6:${PORTSDIR}/ftp/curl >> + curl:${PORTSDIR}/ftp/curl > > Was this change intended? > If yes, I think the change is worth PORTREVISION bumping. > > The package hasn t changed so no need for a bump I appreciate your answer, thanks. But i'm not sure if you understood what I had ment. The shlib ABI version was removed from LIB_DEPENDS and it was not reflected at the log. So the question arises if it was intended. Imho (yep, it's really imho) this change is seriuos enough to go to the log. Working with ports sometimes driving me nuts while searching a particular commit (or even if it ever existed). Well, removing makefile headers may be left out as well as some other info. But imho not this case. Second, the package definitely had changed. The dependency had changed from libcurl.so.6 to libcurl.so. And this is recorded at the package. But in this case the dependency happens to become more wide (i.e. all library version will fit it). While the case with opposite direction (when LIB_DEPENDS converts from *.so to *.so.X) is more clear to me (the bump is vital) current case is not so clear to me. Thanks. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve