From owner-freebsd-hackers Sun Oct 20 0:48:59 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA4CB37B401; Sun, 20 Oct 2002 00:48:57 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D88243E9E; Sun, 20 Oct 2002 00:48:57 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g9K7mi01046318; Sun, 20 Oct 2002 09:48:45 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: David Schultz Cc: Maxim Sobolev , hackers@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: Patch to allow a driver to report unrecoverable write errors to the buf layer In-Reply-To: Your message of "Sat, 19 Oct 2002 21:37:06 PDT." <20021020043706.GA23972@HAL9000.homeunix.com> Date: Sun, 20 Oct 2002 09:48:44 +0200 Message-ID: <46317.1035100124@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021020043706.GA23972@HAL9000.homeunix.com>, David Schultz writes: >> Yes, I noticed that appeared at some time. That misfeature should be >> removed in toto. >> >> If a retry can solve the issue, it's the drivers responsibility to >> retry as much as makes sense and then fail if it doesn't work. >> >> Neither the buf nor the bio layer should get involved in those >> retries. > >Yeah, I mentioned this problem back in April when I wrote a (still >uncommitted) one-line patch to fix an infinite loop in the msdosfs >code involving write failures. It seems like you absolutely have to be able to propagate failures up to higher layers in order to >solve the retry problem. Otherwise, transient errors >(e.g. removing and then reinserting a floppy disk) would cause >filesystem corruption because the vnode layer would be unaware >that some buffers had been dropped. How hard would it be to fix this? Trivially simple, unless the person who added this wart freaks out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message