From owner-freebsd-arch@FreeBSD.ORG Sat Aug 30 05:33:30 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5433EFB; Sat, 30 Aug 2014 05:33:30 +0000 (UTC) Received: from mail-la0-x22d.google.com (mail-la0-x22d.google.com [IPv6:2a00:1450:4010:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 430481D93; Sat, 30 Aug 2014 05:33:30 +0000 (UTC) Received: by mail-la0-f45.google.com with SMTP id pn19so3715307lab.4 for ; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=5O5zyU14ICNb0mAwlFS3aow3W2oDlwrfOEY094VwpOY=; b=ZrB4N5HAxLWw2XuhwM0MvbaOd0fqrUY9vzCElKhi/sxRiluBU9Hc4SaTxH2BNAN3wM De/CNgOXhi16NfQfXvTJyxFXv8ytWFEDWIWVbPIl5GTXH8kO+ml1CTcm+vE9rbfkCukG Go/4+lNr3ZxEZIckqQ0rDXokaZvHjQhzeoGQ9FaqgxzMSeJ6TNwpup9b/wFowNwBvivW hYrk4rc1MGZNPC+bRiKZRYK9++8gyfhqqLTYqJUXKhvgsM/rJFCwWEXkhgbVlEF466iQ QiQ3XFO4e2hWU0XHTeU+XYX73rwK96H/FfDZqFczB9LckUGVWDyvs+jNZL7Zvo8XbCuU N3Og== MIME-Version: 1.0 X-Received: by 10.152.9.42 with SMTP id w10mr15564169laa.9.1409376807716; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.152.144.2 with HTTP; Fri, 29 Aug 2014 22:33:27 -0700 (PDT) In-Reply-To: References: <20140828171859.GA81757@troutmask.apl.washington.edu> Date: Sat, 30 Aug 2014 07:33:27 +0200 X-Google-Sender-Auth: aWjFVkS6R5-j0PUf_BVS6yr6j8o Message-ID: Subject: Re: Lock annotations: enable them for libpthread, libstdthreads From: Ed Schouten To: Steve Kargl Content-Type: text/plain; charset=UTF-8 Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2014 05:33:31 -0000 Hi, On 28 August 2014 19:34, Ed Schouten wrote: > My gut feeling is that impact is minimal. Buildworlds seem to take > approximately the same time, mainly because we don't have that many > annotated objects/functions/expressions. I will do some measurements. Some measurements: I've done five 'make buildworlds' with -Wthread-safety and five without. This was just a single-threaded build (no -j). Real time to build world: -Wthread-safety 1:12:55.60 1:12:48.81 1:12:56.33 1:12:44.58 1:12:48.14 -Wno-thread-safety 1:12:50.50 1:12:52.43 1:12:48.20 1:12:42.85 1:12:43.19 That said, this a pretty fast box (i7 4770) with 32 GB of RAM. Unfortunately, I currently don't have any system running FreeBSD that is significantly slower than that. So if you still have any concerns regarding build times, I would really appreciate it if you'd test this patch yourself. Thanks, -- Ed Schouten