From owner-svn-ports-head@freebsd.org Fri Aug 21 19:23:28 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B60A89BFD57; Fri, 21 Aug 2015 19:23:28 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216]) by mx1.freebsd.org (Postfix) with ESMTP id 7C81C1ACE; Fri, 21 Aug 2015 19:23:28 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from hive.panopticon (unknown [78.153.152.119]) by vps.amdmi3.ru (Postfix) with ESMTPS id 046B1B059C; Fri, 21 Aug 2015 22:23:26 +0300 (MSK) Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 31796B71; Fri, 21 Aug 2015 22:20:48 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id C4A144A2ED; Fri, 21 Aug 2015 22:17:37 +0300 (MSK) Date: Fri, 21 Aug 2015 22:17:37 +0300 From: Dmitry Marakasov To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394970 - head/devel/love07 Message-ID: <20150821191737.GB41937@hades.panopticon> References: <201508211600.t7LG05HP050267@repo.freebsd.org> <20150821171523.GA49960@FreeBSD.org> <20150821172406.GA41937@hades.panopticon> <20150821185335.GA86849@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150821185335.GA86849@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2015 19:23:28 -0000 * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > May I ask you to quote more accurately? It's hard to follow since I did not > say anything about flavors (which, FWIW, were used purely as an example) in > the second paragraph (which was essential, yet went unreplied). > > Apparently I did not make myself clear. I understand the "targets which > depend on whether option is enabled or disabled" part; what I don't > understand is the necessity of conditional installing of handful of text > files whose existence does not depend on any option. > > After we entered staging era, we started to get rid of .if ${PORTDOCS} > checks because we could use the benefit of dumping everything possible [1] > into stagedir and then cherry-pick the bits we want to package (it can be > one package or several depending on the options). These `post-install > -DOCS-on: ' targets kind go against the > idea of staging as it looks to me ATM unless I'm missing something obvious > here. Doc files are installed optionally based on DOCS option. Yes, the framework handles them well by not including them into the package if DOCS option is disabled, but there's no need to install them in that case. Yes, not installing couple of files does not give any build time improvements, but it's just more explicit and clean and may be easily done with new optional targets. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru