From owner-p4-projects@FreeBSD.ORG  Sun May 25 03:52:39 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8BAE237B404; Sun, 25 May 2003 03:52:38 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6ABB537B401
	for <perforce@freebsd.org>; Sun, 25 May 2003 03:52:37 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1101C43F93
	for <perforce@freebsd.org>; Sun, 25 May 2003 03:52:37 -0700 (PDT)
	(envelope-from des@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4PAqa0U062881
	for <perforce@freebsd.org>; Sun, 25 May 2003 03:52:36 -0700 (PDT)
	(envelope-from des@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4PAqavg062878
	for perforce@freebsd.org; Sun, 25 May 2003 03:52:36 -0700 (PDT)
Date: Sun, 25 May 2003 03:52:36 -0700 (PDT)
Message-Id: <200305251052.h4PAqavg062878@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	des@freebsd.org using -f
From: Dag-Erling Smorgrav <des@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 31851 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 May 2003 10:52:39 -0000

http://perforce.freebsd.org/chv.cgi?CH=31851

Change 31851 by des@des.at.des.thinksec.com on 2003/05/25 03:52:31

	No need to explicitly clear pointers now that we use FREE().

Affected files ...

.. //depot/projects/openpam/lib/openpam_ttyconv.c#19 edit
.. //depot/projects/openpam/lib/pam_get_authtok.c#24 edit

Differences ...

==== //depot/projects/openpam/lib/openpam_ttyconv.c#19 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/lib/openpam_ttyconv.c#18 $
+ * $P4: //depot/projects/openpam/lib/openpam_ttyconv.c#19 $
  */
 
 #include <sys/types.h>
@@ -181,7 +181,6 @@
 	while (i)
 		FREE(resp[--i]);
 	FREE(*resp);
-	*resp = NULL;
 	RETURNC(PAM_CONV_ERR);
 }
 

==== //depot/projects/openpam/lib/pam_get_authtok.c#24 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/lib/pam_get_authtok.c#23 $
+ * $P4: //depot/projects/openpam/lib/pam_get_authtok.c#24 $
  */
 
 #include <sys/param.h>
@@ -112,10 +112,8 @@
 			FREE(resp);
 			RETURNC(r);
 		}
-		if (strcmp(resp, resp2) != 0) {
+		if (strcmp(resp, resp2) != 0)
 			FREE(resp);
-			resp = NULL;
-		}
 		FREE(resp2);
 	}
 	if (resp == NULL)