From owner-svn-src-head@FreeBSD.ORG Wed Aug 10 13:19:53 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E474B106566B; Wed, 10 Aug 2011 13:19:53 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id A3C078FC0C; Wed, 10 Aug 2011 13:19:53 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:4cdf:3c74:f81e:a1a7] (unknown [IPv6:2001:7b8:3a7:0:4cdf:3c74:f81e:a1a7]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 96B965C59; Wed, 10 Aug 2011 15:19:52 +0200 (CEST) Message-ID: <4E428581.4050803@FreeBSD.org> Date: Wed, 10 Aug 2011 15:20:01 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: Alexander Best References: <201108082036.p78KarlR062810@svn.freebsd.org> <20110809105824.P896@besplex.bde.org> <20110810103831.GA60858@freebsd.org> In-Reply-To: <20110810103831.GA60858@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Jonathan Anderson , Bruce Evans Subject: Re: svn commit: r224721 - head/sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2011 13:19:54 -0000 On 2011-08-10 12:38, Alexander Best wrote: ... > any reason {TIMEVAL,TIMESPEC}_TO_{TIMESPEC,TIMEVAL}()s code is being executed > in a > > do { ... } while (0) > > conditional loop? both macros are also defined in crypto/openssh/defines.h and > don't seem to need that extra one-time-loop. It's a very common C idiom. See: http://stackoverflow.com/questions/154136/why-are-there-sometimes-meaningless-do-while-and-if-else-statements-in-c-c-macr