From owner-freebsd-amd64@FreeBSD.ORG Thu Mar 27 05:40:00 2014 Return-Path: Delivered-To: freebsd-amd64@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CEDB1889 for ; Thu, 27 Mar 2014 05:40:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 92392F64 for ; Thu, 27 Mar 2014 05:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2R5e0Yd027747 for ; Thu, 27 Mar 2014 05:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2R5e08l027746; Thu, 27 Mar 2014 05:40:00 GMT (envelope-from gnats) Resent-Date: Thu, 27 Mar 2014 05:40:00 GMT Resent-Message-Id: <201403270540.s2R5e08l027746@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-amd64@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Takuya ASADA Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 03136867 for ; Thu, 27 Mar 2014 05:39:02 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E4B68F5C for ; Thu, 27 Mar 2014 05:39:01 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s2R5d1Cl048644 for ; Thu, 27 Mar 2014 05:39:01 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s2R5d1Jw048641; Thu, 27 Mar 2014 05:39:01 GMT (envelope-from nobody) Message-Id: <201403270539.s2R5d1Jw048641@cgiserv.freebsd.org> Date: Thu, 27 Mar 2014 05:39:01 GMT From: Takuya ASADA To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: amd64/188010: madt_parse_nmi() checking incorrect flag X-Mailman-Approved-At: Thu, 27 Mar 2014 11:33:42 +0000 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2014 05:40:00 -0000 >Number: 188010 >Category: amd64 >Synopsis: madt_parse_nmi() checking incorrect flag >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-amd64 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 27 05:40:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Takuya ASADA >Release: -CURRENT >Organization: Cloudius Systems >Environment: >Description: madt_parse_nmi() checks ACPI_MADT_TRIGGER_CONFORMS before calling ioapic_set_polarity(), but it should check ACPI_MADT_POLARITY_CONFORMS instead. I suppose this is typo. >How-To-Repeat: I haven't get any problem from this bug >Fix: Patch attached with submission follows: diff --git a/sys/x86/acpica/madt.c b/sys/x86/acpica/madt.c index 9dfb77f..3e8aee5 100644 --- a/sys/x86/acpica/madt.c +++ b/sys/x86/acpica/madt.c @@ -492,7 +492,7 @@ madt_parse_nmi(ACPI_MADT_NMI_SOURCE *nmi) if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS)) ioapic_set_triggermode(ioapic, pin, interrupt_trigger(nmi->IntiFlags, 0)); - if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS)) + if (!(nmi->IntiFlags & ACPI_MADT_POLARITY_CONFORMS)) ioapic_set_polarity(ioapic, pin, interrupt_polarity(nmi->IntiFlags, 0)); } >Release-Note: >Audit-Trail: >Unformatted: