From owner-cvs-all  Mon Nov 19 16: 4:39 2001
Delivered-To: cvs-all@freebsd.org
Received: from Veronica.wmol.com (veronica.wmol.com [208.242.83.241])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9998637B418; Mon, 19 Nov 2001 16:04:29 -0800 (PST)
Received: from rain.hill.hom (24.247.81.122.bay.mi.chartermi.net [24.247.81.122]) by Veronica.wmol.com
 (Vircom SMTPRS 5.0.193) with ESMTP id <B0009540919@Veronica.wmol.com>;
 Mon, 19 Nov 2001 19:01:06 -0500
Date: Mon, 19 Nov 2001 19:04:03 +0000
From: David Hill <david@phobia.ms>
To: "Andrew R. Reiter" <arr@FreeBSD.org>
Cc: yar@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/libexec/ftpd ftpd.c
Message-Id: <20011119190403.7cb2020b.david@phobia.ms>
In-Reply-To: <Pine.NEB.3.96L.1011119165508.75141B-100000@fledge.watson.org>
References: <200111192152.fAJLq3N94389@freefall.freebsd.org>
	<Pine.NEB.3.96L.1011119165508.75141B-100000@fledge.watson.org>
X-Mailer: Sylpheed version 0.6.4 (GTK+ 1.2.10; i386--freebsd5.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 19 Nov 2001 17:00:51 -0500 (EST)
"Andrew R. Reiter" <arr@FreeBSD.org> wrote:

> On Mon, 19 Nov 2001, Yar Tikhiy wrote:
> 
> :yar         2001/11/19 13:52:03 PST
> :
> :  Modified files:
> :    libexec/ftpd         ftpd.c 
> :  Log:
> :  Eliminate another instance of the old and well-known
> :  DoS bug that the select(2)/accept(2) pair is called on
> :  a socket that is in the blocking I/O mode.  The bug is
> :  triggered if a selected connection dies before the accept(2)
> :  leading to the accept(2) blocking virtually forever.
> :  
> :  MFC after:      1 week
> :  
> :  Revision  Changes    Path
> :  1.87      +25 -7     src/libexec/ftpd/ftpd.c
> 
> Just as a thought, since I've noted the ftpd mucking, there are two issues
> with the ftp daemon code that are not necesarily critical, but should be
> changed:
>   - Dynamically allocate the fd_set bit arrays
>   - Correct usage of signal handlers to only use set/check flags.
> 
> Got anymore motivation to tackle those? 
> 
> Cheers,
> Andrew
> 
> --
> Andrew R. Reiter
> arr@watson.org
> arr@FreeBSD.org
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message

How about switching ftpd to use kqueue?

- David

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message