From owner-freebsd-ports@FreeBSD.ORG Tue May 15 14:12:49 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4320106566B for ; Tue, 15 May 2012 14:12:49 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 5B37D8FC0C for ; Tue, 15 May 2012 14:12:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sweb; b=G0aR5o XWxNEMuVlX6+Uw8opryPEPcCwbc+hfx+FdvZxguSsJ0uCyeHXV90YWkxEeEHIUgP i8R/J1+JPcs4BCYZ7m6FxNbfs7sKp2UEwx221JkiV2vxoOAhrswtJnFuIv/J58RJ DfglAPYn9DK6+ncB+ZV2z3OUnVPLbIy8ObRkU= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sweb; bh=OG6UBhZaipNc 7TFImsCOldVBKOxO8N/IB773lJ1sHKA=; b=2Hwzhq2991Hyqw4rFdNQHjAwmdQJ xUwvyXpslobsi549m3OwY925i1ae0DODjnvz3WQuCmy4K/jW7m31v49yWODaMEq7 Eryyn2cH02sN8stEjnSbcxmFW90iqtJIPktmMtGPpvKo1Tl8sEqoj6wsBlZO17JS E1teUpYs0a4UcEA= Received: (qmail 48317 invoked from network); 15 May 2012 09:12:41 -0500 Received: from unknown (HELO ?192.168.0.107?) (bryan@shatow.net@74.94.87.209) by sweb.xzibition.com with ESMTPA; 15 May 2012 09:12:41 -0500 Message-ID: <4FB26458.4050401@shatow.net> Date: Tue, 15 May 2012 09:12:40 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: bf1783@gmail.com References: In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.org Subject: Re: BUILD_DEPENDS= RUN_DEPENDS= X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2012 14:12:49 -0000 On 05/14/2012 11:10 PM, b. f. wrote: >> Hi, >> >> I was trying to append to these in my /etc/make.conf and found that a >> large (thousands) number of ports are using = instead of +=, thus >> destroying any user-supplied depends. >> >> The use case for wanting to do this is to force devel/ccache to be a >> build dependency on all ports, for package building. Or to force in a >> particular library along with LDFLAGS into particular ports. This is >> achievable by modifying bsd.local.mk, but is not ideal. >> >> This goes along with updating all CLFAGS/LDFLAGS to use += instead of =. >> >> If there is no objection to this route, I will follow-up with a patch/PR >> to update the ports and handbook. > > Only those user-supplied depends that are added in makefiles included > before those lines are parsed (like make.conf) can be affected. But > there are a number of other makefiles that exist solely for > customizations like you describe -- you mentioned one of them, > bsd.local.mk. It is safer and more efficient to move as many of your > customizations as possible out of make.conf, and into these other > makefiles, as was intended. "+=" was used for a few other variables > because these few were often already defined in make.conf for other > reasons -- but we are trying to discourage abuse of make.conf, so > making a large number of unnecessary changes to make it possible for > further additions to make.conf is a bad idea. > > b. Alright sounds good. I'll drop the endeavor and stick to bsd.local.mk. Thanks! Regards, Bryan Drewery