From owner-freebsd-current Tue Jun 27 18:35:49 2000 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 1277937B64C for ; Tue, 27 Jun 2000 18:35:43 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id LAA28141; Wed, 28 Jun 2000 11:32:00 +1000 Date: Wed, 28 Jun 2000 11:31:55 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Alexander Langer Cc: Clive Lin , FreeBSD current Subject: Re: let badsect recog IFCHR in 5.0-C In-Reply-To: <20000627173821.A98097@cichlids.cichlids.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 27 Jun 2000, Alexander Langer wrote: > Thus spake Clive Lin (clive@CirX.ORG): > > > - memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > - *name_dir_end = 'r'; > > + // un-needed. > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > + // *name_dir_end = 'r'; > > Use /* */ comments or #if 0. > > Please see style(9) :) 1) Don't "comment out" dead code. Remove it. 2) Use only #if 0 to "comment out code. Comments are unsuitable for "commenting out" code in general, because the code might contain comments, and they are harder to edit and read. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message