From owner-freebsd-ports@FreeBSD.ORG  Wed Oct 12 07:12:57 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 02C3116A41F;
	Wed, 12 Oct 2005 07:12:57 +0000 (GMT)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from smtp-3.dlr.de (smtp-3.dlr.de [195.37.61.187])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6696143D53;
	Wed, 12 Oct 2005 07:12:55 +0000 (GMT)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-3.dlr.de over TLS
	secured channel with Microsoft SMTPSVC(6.0.3790.211); 
	Wed, 12 Oct 2005 09:12:53 +0200
Date: Wed, 12 Oct 2005 09:12:58 +0200 (CEST)
From: Harti Brandt <hartmut.brandt@dlr.de>
X-X-Sender: brandt_h@beagle.kn.op.dlr.de
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: <20051012021112.GA48078@xor.obsecurity.org>
Message-ID: <20051012090453.N63649@beagle.kn.op.dlr.de>
References: <20051012020023.GB40204@xor.obsecurity.org>
	<20051012021112.GA48078@xor.obsecurity.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-OriginalArrivalTime: 12 Oct 2005 07:12:53.0762 (UTC)
	FILETIME=[5D050E20:01C5CEFC]
Cc: ports@FreeBSD.org, re@FreeBSD.org
Subject: Re: Make broken in 6.0 ([ports-i386@pointyhat.freebsd.org:
 empire-1.7 failed on i386 6])
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Harti Brandt <harti@freebsd.org>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2005 07:12:57 -0000

On Tue, 11 Oct 2005, Kris Kennaway wrote:

KK>On Tue, Oct 11, 2005 at 10:00:24PM -0400, Kris Kennaway wrote:
KK>> For some reason a number of ports are failing with this error on the
KK>> latest build.  I suspect that a change may have been merged to some
KK>> part of the base system that broke them.  Can someone please take a
KK>> look?

I actually doubt that the $(shell ...) construct was ever supported in our 
make. The canonical way to assign the output of a shell command to a 
variable is

VERSION != sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p'

we also support the SysV syntax:

VERSION :sh= ...

although that's not documented and should be avoided.

harti

KK>> 
KK>> Kris
KK>
KK>> ===>  Configuring for empire-1.7
KK>> ===>  Building for empire-1.7
KK>> Unknown modifier ' '
KK>> 
KK>> Error expanding embedded variable.
KK>> *** Error code 2
KK>
KK>This seems to be from make trying to execute a $(shell ...) command.
KK>This seems to be broken:
KK>
KK>VERSION=$(shell sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p')
KK>
KK>xor# make -V VERSION
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP
KK>+PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP:.*
KK>
KK>I think this must have been broken in make(1) some time ago (if it
KK>ever worked)..the workaround for now is probably to make these ports
KK>use gmake instead [1].
KK>
KK>Kris
KK>
KK>[1] jasone actually discovered this when I was testing some of his
KK>other patches, which flagged this more explicitly as an error.