From owner-cvs-src@FreeBSD.ORG  Mon Aug 18 19:59:32 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3888B37B401; Mon, 18 Aug 2003 19:59:32 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 241A243FA3; Mon, 18 Aug 2003 19:59:28 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id MAA02870;
	Tue, 19 Aug 2003 12:59:19 +1000
Date: Tue, 19 Aug 2003 12:59:18 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "David O'Brien" <obrien@FreeBSD.org>
In-Reply-To: <20030818150756.GA63211@dragon.nuxi.com>
Message-ID: <20030819124646.T86332@gamplex.bde.org>
References: <200308180036.h7I0aVFl033156@repoman.freebsd.org>
	<20030818150756.GA63211@dragon.nuxi.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Shin-ichi Yoshimoto <yosimoto@waishi.jp>
Subject: Re: cvs commit: src/etc Makefile src/etc/isdn Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Aug 2003 02:59:32 -0000

On Mon, 18 Aug 2003, David O'Brien wrote:

> On Mon, Aug 18, 2003 at 01:33:32PM +0900, Shin-ichi Yoshimoto wrote:
> > Subject: cvs commit: src/etc Makefile src/etc/isdn Makefile,
> > On Sun, 17 Aug 2003 17:36:31 -0700 (PDT), David E. O'Brien wrote:
> > >   1.10      +4 -2      src/etc/isdn/Makefile
> >
> > You forgot ".include <bsd.prog.mk>"
>
> Eeek, will fix.  But why not include <bsd.own.mk> instead?

Because <bsd.own.mk> is (mostly) an implementation detail.

Anyway, isdn/Makefile would need <bsd.prog.mk> if it were a BSD makefile.
Most of this bug suite is caused by isdn/Makefile using home made (and
wrong) install rules.  isdn/Makefile should look much like rc.d/Makefile
(with FILES, etc.) except it shouldn't have the style bug of including
<bsd.own.mk>.

There are a few other Makefile that include <bsd.own.mk> directly.  This
seems to be just a style bug except in src/Makefile.inc1.

Bruce