From owner-freebsd-ports@FreeBSD.ORG Wed Jul 29 20:07:22 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00B941065672 for ; Wed, 29 Jul 2009 20:07:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A41DF8FC19 for ; Wed, 29 Jul 2009 20:07:21 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 30791 invoked by uid 399); 29 Jul 2009 20:07:18 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 29 Jul 2009 20:07:18 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A70ABF4.9090906@FreeBSD.org> Date: Wed, 29 Jul 2009 13:07:16 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.22 (X11/20090728) MIME-Version: 1.0 To: Mel Flynn References: <4A709B81.5070905@FreeBSD.org> <200907291133.35055.mel.flynn+fbsd.questions@mailing.thruhere.net> In-Reply-To: <200907291133.35055.mel.flynn+fbsd.questions@mailing.thruhere.net> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, "Dan Mahoney, System Admin" , freebsd-questions@freebsd.org, freebsd-ports@freebsd.org Subject: Re: Don't know how to make /usr/ports/dns/bind96/work/.build.... X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2009 20:07:22 -0000 Mel Flynn wrote: > On Wednesday 29 July 2009 10:57:05 Doug Barton wrote: >> Dan Mahoney, System Admin wrote: >>>> I believe Mel is right here. 'make clean ; make config ; make' worked >>>> for me. >>> As does a second make after getting this error, but it's nonintuitive, >>> and probably a ports bug. >> I'm not sure why 'make clean' is nonintuitive in the context of >> changing OPTIONS. What is your expectation of how it should work? > > What he means is that make without arguments or make install as per handbook, > will build the build target which will invoke the config target if OPTIONS > changed or no options file is found. In the original post the build was already done, but it had been done with a different set of OPTIONS choices. My question is, why is running 'make clean' in the scenario of: 1. build 2. change options [make clean should happen here] 3. install not intuitive? > However, this is a corner case, as it applies to: > - Ports that change PREFIX using OPTIONS > - For which no options file is available or the OPTIONS list has changed > - When the PREFIX is actually changed through toggling the appropriate option. > > This applies surely to less then 100 (probably more like a dozen) ports on the > 18k that are in the tree and only affects people who do not use ports-mgmt > software. As such it is not worth fixing, IMHO. Forget this particular problem, you're right that the fact that the ports system doesn't know how to deal with an obsoleted build-cookie actually is a corner case. My concern is the general user expectation of what should happen in this scenario. If it's generally expected that magic should happen if a users changes OPTIONS after building the port we need to make that magic happen. Otherwise people will be installing things that are not built the way that they think they are. Doug -- This .signature sanitized for your protection