From owner-cvs-src@FreeBSD.ORG Sat Jan 6 20:46:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8068316A403; Sat, 6 Jan 2007 20:46:02 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 72AE513C442; Sat, 6 Jan 2007 20:46:02 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l06Kk2kQ061817; Sat, 6 Jan 2007 20:46:02 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l06Kk26r061816; Sat, 6 Jan 2007 20:46:02 GMT (envelope-from rodrigc) Message-Id: <200701062046.l06Kk26r061816@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 6 Jan 2007 20:46:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2007 20:46:02 -0000 rodrigc 2007-01-06 20:46:02 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vfsops.c Log: When performing a mount update to change a mount from read-only to read-write, do not call markvoldirty() until the mount has been flagged as read-write. Due to the nature of the msdosfs code, this bug only seemed to appear for FAT-16 and FAT-32. This fixes the testcase: #!/bin/sh dd if=/dev/zero bs=1m count=1 oseek=119 of=image.msdos mdconfig -a -t vnode -f image.msdos newfs_msdos -F 16 /dev/md0 fd120m mount_msdosfs -o ro /dev/md0 /mnt mount | grep md0 mount -u -o rw /dev/md0; echo $? mount | grep md0 umount /mnt mdconfig -d -u 0 PR: 105412 Tested by: Eugene Grosbein Revision Changes Path 1.156 +10 -4 src/sys/fs/msdosfs/msdosfs_vfsops.c