From owner-svn-src-all@FreeBSD.ORG Wed May 28 12:59:10 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15C8065A; Wed, 28 May 2014 12:59:10 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C81B52411; Wed, 28 May 2014 12:59:09 +0000 (UTC) Received: from laptop015.home.selasky.org (c123.sec.cl.cam.ac.uk [128.232.18.123]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 433DE248009; Wed, 28 May 2014 14:59:02 +0200 (CEST) Message-ID: <5385DDBF.4000007@selasky.org> Date: Wed, 28 May 2014 14:59:43 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r266798 - head/usr.sbin/usbdump References: <201405281227.s4SCRgKs038491@svn.freebsd.org> <20140528124904.GI50679@FreeBSD.org> In-Reply-To: <20140528124904.GI50679@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2014 12:59:10 -0000 On 05/28/14 14:49, Gleb Smirnoff wrote: > On Wed, May 28, 2014 at 12:27:42PM +0000, Hans Petter Selasky wrote: > H> Author: hselasky > H> Date: Wed May 28 12:27:41 2014 > H> New Revision: 266798 > H> URL: http://svnweb.freebsd.org/changeset/base/266798 > H> > H> Log: > H> Fix for big endian architectures. The "up_address" field is 8-bit and > H> does not need byte swapping. > H> > H> MFC after: 1 week > > Do we need the assignment then? I'm surprised that compiler doesn't fail on that. > Right, fixed. --HPS