From owner-freebsd-current@FreeBSD.ORG Wed Jan 21 10:17:22 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E96023B4; Wed, 21 Jan 2015 10:17:22 +0000 (UTC) Received: from smtp.digiware.nl (smtp.digiware.nl [31.223.170.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A240F91B; Wed, 21 Jan 2015 10:17:22 +0000 (UTC) Received: from rack1.digiware.nl (unknown [127.0.0.1]) by smtp.digiware.nl (Postfix) with ESMTP id 725A816A403; Wed, 21 Jan 2015 11:17:20 +0100 (CET) X-Virus-Scanned: amavisd-new at digiware.nl Received: from smtp.digiware.nl ([127.0.0.1]) by rack1.digiware.nl (rack1.digiware.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G3Mue_PUkLde; Wed, 21 Jan 2015 11:17:19 +0100 (CET) Received: from [IPv6:2001:4cb8:3:1:6455:2a07:d7dc:ef6e] (unknown [IPv6:2001:4cb8:3:1:6455:2a07:d7dc:ef6e]) by smtp.digiware.nl (Postfix) with ESMTP id 323AA16A401; Wed, 21 Jan 2015 11:17:19 +0100 (CET) Message-ID: <54BF7CAB.4050008@digiware.nl> Date: Wed, 21 Jan 2015 11:17:15 +0100 From: Willem Jan Withagen Organization: Digiware Management b.v. User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Garrett Cooper Subject: Re: Head not buildin in zfs.c References: <54BF72A9.5000608@digiware.nl> <31627BCE-2B7A-44AA-9442-2D9347C1F571@gmail.com> <54BF79E1.3060401@digiware.nl> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: Benjamin Perrault , FreeBSD Current , Will Andrews X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 10:17:23 -0000 On 2015-01-21 11:08, Garrett Cooper wrote: > On Jan 21, 2015, at 2:05, Willem Jan Withagen wrote: > >> On 2015-01-21 10:51, Benjamin Perrault wrote: >>> >>>> On Jan 21, 2015, at 1:34 AM, Willem Jan Withagen >>>> wrote: >>>> >>>> >>>> Found this lastnight build. Just fetched the most recent HEAD. >>>> Error remains >>>> >>>> --- zfs/zfs.o --- In file included from >>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../zfs.c:39: >>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../../../cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:538:9: >>>> error: 'NSEC_TO_TICK' macro redefined [-Werror,-Wmacro-redefined] >>>> #define NSEC_TO_TICK(usec) ((usec) / (NANOSEC / hz)) ^ >>>> /usr/srcs/src11/src/lib/libprocstat/zfs/../../../sys/cddl/compat/opensolaris/sys/time.h:54:9: >>>> note: previous definition is here #define NSEC_TO_TICK(nsec) >>>> ((nsec) / (NANOSEC / hz)) ^ /etc/{make,src}.conf are empty >>>> >> >>> I’m seeing the exact same issue. It began for me at r277472 and is >>> still persisting as of r277482 ( the most recent HEAD as of writing >>> this email ). >> >> Well, the problem is reported several times during compilation. >> This is the first warning that also has -Werror, and hence building stops. >> >> I have not been able to find where this -Werror "all of a sudden" pops up. >> >> Has to be in any of those commits... > > It’s a mismatch in the macro definitions, made in the commit below. > I’m testing out a fix for it right now. > Thanks for the report! > > ------------------------------------------------------------------------ > r277449 | will | 2015-01-20 14:29:27 -0800 (Tue, 20 Jan 2015) | 2 lines > > NSEC_TO_TICK(usec) -> NSEC_TO_TICK(nsec) > Right, picky nasty compilers being fussy. ;) I did in look in the svn log of both .h files, but overlooked what you just found..... Need more coffee. I'll be waiting the the fix in the tree.. Thanx, --WjW