From owner-cvs-src@FreeBSD.ORG Sun Jul 29 21:42:33 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8904516A421; Sun, 29 Jul 2007 21:42:33 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 5EE0A13C483; Sun, 29 Jul 2007 21:42:33 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.14.1/8.14.1) with ESMTP id l6TLgP7w086340; Sun, 29 Jul 2007 14:42:33 -0700 (PDT) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.14.1/8.14.1/Submit) with ESMTP id l6TLgPY6086337; Sun, 29 Jul 2007 14:42:25 -0700 (PDT) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Sun, 29 Jul 2007 14:42:24 -0700 (PDT) From: mjacob@freebsd.org To: "Bjoern A. Zeeb" In-Reply-To: <20070729211359.C31116@maildrop.int.zabbadoz.net> Message-ID: <20070729143653.E86313@ns1.feral.com> References: <200707290131.l6T1VY8g026872@repoman.freebsd.org> <46AC987A.9040501@freebsd.org> <20070729184123.S44136@mp2.macomnet.net> <20070729095743.N84864@ns1.feral.com> <20070729101357.A84864@ns1.feral.com> <20070729101935.D84864@ns1.feral.com> <20070729211359.C31116@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2007 21:42:33 -0000 On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote: > On Sun, 29 Jul 2007, mjacob@freebsd.org wrote: > >> Here's what probably works. I'll do the test compiles. > > If I am not wrong it will not. > > The follwoing two files have comments at the beginning to explain the > changes. > I don't like the extern char *tcpstates[] but it seems to be the best > solution for now. No, that's what's actually wrong. tcpstates has to be static to honor the intent of the original author. If you want to do something extern then the actual tcpstates should go into tcp_debug.c. However, this is slightly less flexible in that the way it is now each source file can include this array simply by defining TCPSTATES (independent of TCPDEBUG as an option). This is all incredible microopt goop. The only reason I didn't just simply make this an always visible thing is that it really dates to all intents and purposes from the end of the PDP-11 era where the inclusion of this array or not was really worth worrying about.