From owner-freebsd-arch@FreeBSD.ORG  Sat Aug 30 16:22:20 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AAFDFC73;
 Sat, 30 Aug 2014 16:22:20 +0000 (UTC)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask.apl.washington.edu",
 Issuer "troutmask.apl.washington.edu" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6C9021C13;
 Sat, 30 Aug 2014 16:22:20 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
 [127.0.0.1])
 by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id s7UGMFar094743
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 30 Aug 2014 09:22:15 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id s7UGMF6F094742;
 Sat, 30 Aug 2014 09:22:15 -0700 (PDT) (envelope-from sgk)
Date: Sat, 30 Aug 2014 09:22:15 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Ed Schouten <ed@80386.nl>
Subject: Re: Lock annotations: enable them for libpthread, libstdthreads
Message-ID: <20140830162215.GA94722@troutmask.apl.washington.edu>
References: <CAJOYFBBbzu9ouwfUk1+1MLW0B2y+5JTD9-b0+kiymOT=xKU0uQ@mail.gmail.com>
 <20140828171859.GA81757@troutmask.apl.washington.edu>
 <CAJOYFBAo6KOuWuXcduA8DJZxNg7W8bAhM5ydGAhPKCdLMjWsvQ@mail.gmail.com>
 <CAJOYFBB4+O6N2yQDei7jNxKAb4T1wZ=HjiSV7GHF7gYcHB3auA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJOYFBB4+O6N2yQDei7jNxKAb4T1wZ=HjiSV7GHF7gYcHB3auA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Aug 2014 16:22:20 -0000

On Sat, Aug 30, 2014 at 07:33:27AM +0200, Ed Schouten wrote:
> 
> On 28 August 2014 19:34, Ed Schouten <ed@80386.nl> wrote:
> > My gut feeling is that impact is minimal. Buildworlds seem to take
> > approximately the same time, mainly because we don't have that many
> > annotated objects/functions/expressions. I will do some measurements.
> 
> Some measurements: I've done five 'make buildworlds' with
> -Wthread-safety and five without. This was just a single-threaded
> build (no -j). Real time to build world:
> 
> -Wthread-safety
> 
> 1:12:55.60
> 1:12:48.81
> 1:12:56.33
> 1:12:44.58
> 1:12:48.14
> 
> -Wno-thread-safety
> 
> 1:12:50.50
> 1:12:52.43
> 1:12:48.20
> 1:12:42.85
> 1:12:43.19
> 
> That said, this a pretty fast box (i7 4770) with 32 GB of RAM.
> Unfortunately, I currently don't have any system running FreeBSD that
> is significantly slower than that. So if you still have any concerns
> regarding build times, I would really appreciate it if you'd test this
> patch yourself.
> 

Thanks for testing.  The above reduces my fear of feature
creep where each change only adds a little bit more time
to buildworld.

-- 
Steve