From owner-svn-src-all@FreeBSD.ORG Mon Jun 2 10:25:05 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B9A1BA; Mon, 2 Jun 2014 10:25:05 +0000 (UTC) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF5EA2251; Mon, 2 Jun 2014 10:25:04 +0000 (UTC) Received: from smtp.greenhost.nl ([213.108.104.138]) by smarthost1.greenhost.nl with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1WrPAF-0000wV-1n; Mon, 02 Jun 2014 12:08:23 +0200 Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: "Bjoern A. Zeeb" , "Gleb Smirnoff" Subject: Re: svn commit: r266822 - head/sys/netipsec References: <201405282301.s4SN1Kcv020803@svn.freebsd.org> <20140529034442.GS50679@FreeBSD.org> Date: Mon, 02 Jun 2014 12:08:21 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: <20140529034442.GS50679@FreeBSD.org> User-Agent: Opera Mail/12.17 (Win32) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: - X-Spam-Score: -1.5 X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED, BAYES_05 autolearn=disabled version=3.3.1 X-Scan-Signature: 74bd734068bee68206891dc8710ce62a Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 10:25:05 -0000 On Thu, 29 May 2014 05:44:42 +0200, Gleb Smirnoff wrote: > On Wed, May 28, 2014 at 11:01:20PM +0000, Bjoern A. Zeeb wrote: > B> Author: bz > B> Date: Wed May 28 23:01:20 2014 > B> New Revision: 266822 > B> URL: http://svnweb.freebsd.org/changeset/base/266822 > B> > B> Log: > B> Use IPv4 statistics in ipsec4_process_packet() rather than the IPv6 > B> version. This also unbreaks the NOINET6 builds after r266800. > B> > B> Modified: > B> head/sys/netipsec/ipsec_output.c > B> > B> Modified: head/sys/netipsec/ipsec_output.c > B> > ============================================================================== > B> --- head/sys/netipsec/ipsec_output.c Wed May 28 19:59:27 > 2014 (r266821) > B> +++ head/sys/netipsec/ipsec_output.c Wed May 28 23:01:20 > 2014 (r266822) > B> @@ -576,7 +576,7 @@ ipsec4_process_packet( > B> DPRINTF(("%s: unsupported protocol family %u\n", > B> __func__, dst->sa.sa_family)); > B> error = EPFNOSUPPORT; > B> - IPSEC6STAT_INC(ips_out_inval); > B> + IPSECSTAT_INC(ips_out_inval); > B> goto bad; > B> } > B> error = (*sav->tdb_xform->xf_output)(m, isr, NULL, i, off); > B> @@ -739,4 +739,4 @@ bad: > B> m_freem(m); > B> return error; > B> } > B> -#endif /*INET6*/ > B> \ No newline at end of file > B> +#endif /*INET6*/ > > Is there any reason to keep the line '\ No newline at end of file' when > it is no longer at the end of the file? > The '\ No newline at end of file' is part of the output of svn diff. It is not actual text in the file. I hope... :-) NB: editors on Windows very often forget the last newline, so I see this message a lot at my work. Ronald.