From owner-svn-src-all@FreeBSD.ORG Mon Jun 2 13:23:46 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [8.8.178.116]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8A7FD76; Mon, 2 Jun 2014 13:23:46 +0000 (UTC) Received: from butcher-nb.yandex.net (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) by mx2.freebsd.org (Postfix) with ESMTP id 3821F2E83; Mon, 2 Jun 2014 13:23:44 +0000 (UTC) Message-ID: <538C7AC3.7030405@FreeBSD.org> Date: Mon, 02 Jun 2014 17:23:15 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Ian Lepore Subject: Re: svn commit: r266970 - stable/10/sys/geom References: <201406021014.s52AE3DY033480@svn.freebsd.org> <1401714438.20883.83.camel@revolution.hippie.lan> In-Reply-To: <1401714438.20883.83.camel@revolution.hippie.lan> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-10@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 13:23:46 -0000 On 02.06.2014 17:07, Ian Lepore wrote: >> ============================================================================== >> --- stable/10/sys/geom/geom_event.c Mon Jun 2 07:08:34 2014 (r266969) >> +++ stable/10/sys/geom/geom_event.c Mon Jun 2 10:14:03 2014 (r266970) >> @@ -206,6 +206,14 @@ g_orphan_register(struct g_provider *pp) >> KASSERT(cp->geom->orphan != NULL, >> ("geom %s has no orphan, class %s", >> cp->geom->name, cp->geom->class->name)); >> + /* >> + * XXX: g_dev_orphan method does deferred destroying >> + * and it is possible, that other event could already >> + * call the orphan method. Check consumer's flags to >> + * do not schedule it twice. >> + */ >> + if (cp->flags & G_CF_ORPHAN) >> + continue; >> cp->flags |= G_CF_ORPHAN; >> cp->geom->orphan(cp); >> } >> > > Why is this comment flagged with XXX? Doesn't that generally mean that > more action or further analysis in the future is required? Nothing > about the comment itself indicates that there's more work to do. I suspect that there are some another places, where similar problem can occurs. It needs more attention. I just did fix for the easy reproducible panic. -- WBR, Andrey V. Elsukov