From owner-svn-src-all@freebsd.org Sat Jan 23 04:32:10 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0BB08A8E4E1; Sat, 23 Jan 2016 04:32:10 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id C76D11B17; Sat, 23 Jan 2016 04:32:09 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lgwl-lstewart2.corp.netflix.com (c110-22-60-167.eburwd6.vic.optusnet.com.au [110.22.60.167]) by lauren.room52.net (Postfix) with ESMTPSA id 92B5F7E84F; Sat, 23 Jan 2016 15:32:06 +1100 (EST) Subject: Re: svn commit: r294535 - in head/sys/netinet: . cc tcp_stacks To: "Bjoern A. Zeeb" , George Neville-Neil References: <201601212234.u0LMYpKT009948@repo.freebsd.org> <56A1D6B2.1010406@freebsd.org> <058BD5D5-C1AC-45DA-B6BE-2EDC4D64F67F@neville-neil.com> Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Lawrence Stewart X-Enigmail-Draft-Status: N1110 Message-ID: <56A30232.7040202@freebsd.org> Date: Sat, 23 Jan 2016 15:31:46 +1100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.4 required=5.0 tests=DNS_FROM_AHBL_RHSBL, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no version=3.3.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2016 04:32:10 -0000 On 01/23/16 03:06, Bjoern A. Zeeb wrote: > >> On 22 Jan 2016, at 15:21 , George Neville-Neil wrote: >> >> >> >> On 22 Jan 2016, at 2:13, Lawrence Stewart wrote: >> >>> Hi Gleb, >>> >>> On 01/22/16 09:34, Gleb Smirnoff wrote: >>>> Author: glebius >>>> Date: Thu Jan 21 22:34:51 2016 >>>> New Revision: 294535 >>>> URL: https://svnweb.freebsd.org/changeset/base/294535 >>>> >>>> Log: >>>> - Rename cc.h to more meaningful tcp_cc.h. >>> >>> As a bit of historical context, the naming was intentionally protocol >>> agnostic because it was originally hoped that the CC framework could be >>> shared between multiple CC aware transports, and the design went to some >>> lengths to accommodate that possibility (e.g. the ccv_container union in >>> struct cc_var). SCTP was the obvious potential in tree consumer at the >>> time, and other protocols like DCCP were considered as well. >>> >>> This hasn't come about to date, but I'm not sure what value is obtained >>> from your rename change unless we decide to completely give up on shared >>> CC and if we do that, this change doesn't go far enough and we can >>> further simplify the framework to make it entirely TCP specific e.g. we >>> should probably do away with struct cc_var. >>> >>> I'd argue in favour of reverting the rename and if you're gung ho about >>> making the framework TCP specific, we can start a public discussion >>> about what that should look like. >>> >> >> I actually was wondering about this as well. I think it ought to be reverted to agnostic. > > I probably share that view but I also agree that cc.h is not a good name. > > So before we entirely revert this, can when maybe come up with a name that is better than cc.h or tcp_cc.h and only make this one more change forward rather than going back to the previous status quo? I don't object to a name change if it's desired by others, but I don't have any suggestions to offer and would personally just stick with cc.h Cheers, Lawrence