From owner-svn-src-all@FreeBSD.ORG Mon Jun 2 18:42:18 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C39F5C41; Mon, 2 Jun 2014 18:42:18 +0000 (UTC) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7658B26FE; Mon, 2 Jun 2014 18:42:18 +0000 (UTC) Received: from [172.29.2.230] ([66.129.239.13]) (authenticated bits=0) by mail.xcllnt.net (8.14.9/8.14.9) with ESMTP id s52IgFGq010665 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Jun 2014 11:42:16 -0700 (PDT) (envelope-from marcel@xcllnt.net) Content-Type: multipart/signed; boundary="Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net From: Marcel Moolenaar In-Reply-To: Date: Mon, 2 Jun 2014 11:42:10 -0700 Message-Id: References: <201406021754.s52Hsd1B039620@svn.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.1878.2) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 18:42:18 -0000 --Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Jun 2, 2014, at 11:27 AM, Adrian Chadd wrote: > .. and actually, bikeshedding for a moment, would we be able to move a > lot of these accessor methods over to inlines? Would that break the > Juniper way of doing things? That would definitely break Juniper as it doesn't give a stable ABI. I've suggested an approach that allows for both, but it was deemed unnecessary. The argument being that the function call overhead is negligible. We can always revisit that decision if needed... -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlOMxYIACgkQpgWlLWHuifYNZwCgh5CbW/ZPwAnW7zIjoonnku8i lN4AoIih2kbiZMZj6p02wpQfegIUOses =K8Dy -----END PGP SIGNATURE----- --Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3--