From owner-freebsd-java@FreeBSD.ORG Wed Jan 21 22:19:18 2009 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0BA0106564A for ; Wed, 21 Jan 2009 22:19:18 +0000 (UTC) (envelope-from hq@freebsd.org) Received: from 27.mail-out.ovh.net (27.mail-out.ovh.net [91.121.30.210]) by mx1.freebsd.org (Postfix) with SMTP id 488BC8FC13 for ; Wed, 21 Jan 2009 22:19:17 +0000 (UTC) (envelope-from hq@freebsd.org) Received: (qmail 9041 invoked by uid 503); 21 Jan 2009 22:29:57 -0000 Received: from b7.ovh.net (HELO mail57.ha.ovh.net) (213.186.33.57) by 27.mail-out.ovh.net with SMTP; 21 Jan 2009 22:29:57 -0000 Received: from b0.ovh.net (HELO queue-out) (213.186.33.50) by b0.ovh.net with SMTP; 21 Jan 2009 22:19:00 -0000 Received: from amarseille-256-1-162-36.w86-211.abo.wanadoo.fr (HELO ?192.168.1.15?) (herve.quiroz@trancecode.org@86.211.125.36) by ns0.ovh.net with SMTP; 21 Jan 2009 22:18:57 -0000 Message-ID: <49779F59.6050209@FreeBSD.org> Date: Wed, 21 Jan 2009 23:19:05 +0100 From: Herve Quiroz User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: andy.lavr@gmail.com References: <49749D98.4080402@reactor-xg.kiev.ua> In-Reply-To: <49749D98.4080402@reactor-xg.kiev.ua> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 11479956925747800583 X-Ovh-Remote: 86.211.125.36 (amarseille-256-1-162-36.w86-211.abo.wanadoo.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-Spam-Check: DONE|H 0.5/N Cc: java@FreeBSD.org Subject: Re: New patch ant.sh.in for FreeBSD ports devel/apache-ant X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 22:19:19 -0000 Hi Andrei, Well, the good side is that I don't think this patch will break anything in the ports tree. OTOH I think you were right in the first place. Looking at the original shell script for the distribution, the correct argument is ${ANT_LIB}. The problem is that there are some Java libraries in the ports tree that are installing custom tasks as JAR files in ${JAVAJARDIR} and these will no longer be available as-is from Ant. I am still unsure if we should go for upstream-behavior correctness or ports behavior stability. So far I know about the following ports that provide an Ant task in the JAR file installed in JAVAJARDIR: - java/java-checkstyle - textproc/ant-xinclude-task Main problem here is that we can't build all Java ports and analyze the content of the JAR files. And using portsearch, I could just list the following ports with a run dependency on devel/apache-ant: - java/xdoclet (JAR contains an Ant task) - www/extsm - www/jetspeed Maybe we could just assume that ports that do not correctly reference their run dependencies are more likely to be broken anyway. BTW, the best way to set this option is through -Dant.library.dir. I'll do more tests with the patch applied and see if any "critical" port fails to build. Herve Andrei V. Lavreniyuk wrote: > Hi! > > > > It will be more correct whew, view attached files - patch-ant.sh.in