From owner-freebsd-current@FreeBSD.ORG Sun Dec 5 18:12:33 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0186F16A4CE for ; Sun, 5 Dec 2004 18:12:33 +0000 (GMT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E31D43D62 for ; Sun, 5 Dec 2004 18:12:32 +0000 (GMT) (envelope-from kientzle@freebsd.org) Received: from freebsd.org (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id iB5ICU90025235; Sun, 5 Dec 2004 10:12:31 -0800 (PST) (envelope-from kientzle@freebsd.org) Message-ID: <41B34F8D.5030401@freebsd.org> Date: Sun, 05 Dec 2004 10:12:29 -0800 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <56325.1102236241@critter.freebsd.dk> In-Reply-To: <56325.1102236241@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Garance A Drosihn cc: current@freebsd.org Subject: Re: [TEST/REVIEW]: rootfs mounting code rework X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Dec 2004 18:12:33 -0000 Poul-Henning Kamp wrote: > In message , Garance A Drosihn writes: > >>At 11:08 AM +0100 12/4/04, Poul-Henning Kamp wrote: >> >>>http://phk.freebsd.dk/patch/rootfs.patch >>> >>>Please test and review. >> >>Hmm. Does this mean that we'll always get the correct partition >>for '/', even if /etc/fstab is wrong for '/'? By "correct", I >>mean "the partition that the kernel was loaded from". > > The loader reads /etc/fstab and picks the entry for '/' out of it > so I can only pressume that whoever did that disagree with your > notion of "correct". Here's a situation that may be worth thinking about: * Working FreeBSD system that uses a separate controller. / is /dev/da4. * Controller blows up. * Connect hard disk to the on-board controller. Note: kernel is now being loaded from /dev/da0, but /etc/fstab still says / is /dev/da4. With the old rootfs code, this system is unbootable. I hope you've considered situations like this. Tim Kientzle