From owner-freebsd-current@FreeBSD.ORG Thu Apr 15 13:30:26 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 815DC106566B; Thu, 15 Apr 2010 13:30:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 52F9E8FC14; Thu, 15 Apr 2010 13:30:26 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id E104946B92; Thu, 15 Apr 2010 09:30:25 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 37E008A026; Thu, 15 Apr 2010 09:30:25 -0400 (EDT) From: John Baldwin To: pluknet Date: Thu, 15 Apr 2010 09:13:50 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <20100312171758.GB31089@dragon.NUXI.org> <201004071549.41672.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201004150913.50097.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 15 Apr 2010 09:30:25 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-current@freebsd.org, Nathan Whitehorn Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2010 13:30:26 -0000 On Thursday 15 April 2010 6:06:24 am pluknet wrote: > On 7 April 2010 23:49, John Baldwin wrote: > > On Tuesday 06 April 2010 11:24:21 am Nathan Whitehorn wrote: > >> pluknet wrote: > >> > Hi, > >> > > >> > the interesting part for me is how to properly assert now a value of e.g. > >> > KINFO_PROC_SIZE varying on err.. different COMPAT_FREEBSD32 arches > >> > (say, FreeBSD would have _kern_proc FreeBSD32 compat layer for top/ps/). > >> > > >> > > >> Probably the cleanest thing would be to set KINFO_PROC_SIZE in > >> machine/proc.h instead of where it is now, and then also define a > >> KINFO_PROC32_SIZE or something in the same place. Also, that would be a > >> really nice feature. > > > > Yes, I think this sounds like the best approach. > > > > Something quick & not clean (well, it passes universe) attached. > So, don't shoot me, please ;-). > It's unclear how to convert those mips o32/n32/o64/n64 though. > I had to make definitions out of _KERNEL visibility as far as > is included from in !_KERNEL only too. Just one suggestion: don't make KINFO_PROC32 #define depenedent on COMPAT_FREEBSD32. It should just be always defined. I think that is the approach Nathan used for the 32-bit ELF machine type. -- John Baldwin