From owner-svn-ports-all@FreeBSD.ORG Fri Mar 22 15:06:30 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2E387341; Fri, 22 Mar 2013 15:06:30 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward15.mail.yandex.net (forward15.mail.yandex.net [IPv6:2a02:6b8:0:801::5]) by mx1.freebsd.org (Postfix) with ESMTP id CF8AF33E; Fri, 22 Mar 2013 15:06:29 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward15.mail.yandex.net (Yandex) with ESMTP id 219929E1268; Fri, 22 Mar 2013 19:06:08 +0400 (MSK) Received: from smtp14.mail.yandex.net (localhost [127.0.0.1]) by smtp14.mail.yandex.net (Yandex) with ESMTP id A60B21B60785; Fri, 22 Mar 2013 19:06:07 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 67U0ZOu0-67UG8Dj7; Fri, 22 Mar 2013 19:06:07 +0400 Message-ID: <514C735F.1050005@passap.ru> Date: Fri, 22 Mar 2013 19:06:07 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130321 Thunderbird/17.0.4 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r314859 - head/palm/jpilot References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org> In-Reply-To: <20130322145344.GA16844@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 22 Mar 2013 15:47:33 +0000 Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2013 15:06:30 -0000 22.03.2013 18:53, Alexey Dokuchaev пишет: > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: >> 21.03.2013 22:27, Baptiste Daroussin пишет: >>> --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) >>> +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) >> [...] >>> -# "?=" and "+=" are for including this Makefile from japanese/jpilot >> >> Not particular to this commit, but rather a general question: >> what is our current policy on comments at the makefile headers? >> I mean non-standard comments (maintainer tips, etc.). Should >> they be deleted? > > I would not delete them (in general case). ACK. > In this particular case I assume > they were deleted because they were stating quite obvious thing: certain > variables with +=/?= are clear indication of master/slave relationship. Unfortunately our standard tool makes this: ----- bsam% cd /usr/ports/palm/jpilot bsam% grep ^# Makefile # Created by: Alex Varju # $FreeBSD: head/palm/jpilot/Makefile 314859 2013-03-21 18:27:17Z bapt $ # Do not edit this makefile header!!! bsam% /usr/ports/Tools/scripts/convert-makefile-header.pl ./Makefile converted bsam% grep ^# Makefile # Created by: Alex Varju # $FreeBSD$ ----- -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve