From owner-svn-src-user@FreeBSD.ORG Fri Nov 23 07:51:52 2012 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 015B4AC for ; Fri, 23 Nov 2012 07:51:52 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 5B2038FC12 for ; Fri, 23 Nov 2012 07:51:51 +0000 (UTC) Received: (qmail 13524 invoked from network); 23 Nov 2012 09:24:15 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 23 Nov 2012 09:24:15 -0000 Message-ID: <50AF2B0F.7000002@freebsd.org> Date: Fri, 23 Nov 2012 08:51:43 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r243414 - user/andre/tcp_workqueue/sys/net References: <201211222043.qAMKh9Zs060179@svn.freebsd.org> <50AEA39D.4080704@freebsd.org> <50AEB2CF.3040904@freebsd.org> <20121123064413.GG84121@FreeBSD.org> In-Reply-To: <20121123064413.GG84121@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Ermal Lu?i , src-committers@FreeBSD.org, svn-src-user@FreeBSD.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2012 07:51:52 -0000 On 23.11.2012 07:44, Gleb Smirnoff wrote: > On Fri, Nov 23, 2012 at 12:18:39AM +0100, Andre Oppermann wrote: > A> > On Thu, Nov 22, 2012 at 11:13 PM, Andre Oppermann > wrote: > A> > > A> > Hello Andre, > A> > you plan to introduce pfil(9) at layer2 as well? > A> > > A> > We already have that in net/if_ethersubr.c for ethernet at least. > A> > > A> > Hmm have missed the addition of that one. > A> > I would have liked that with that hook all the special cases(bridge/netgraph/carp/... to go away. > A> > A> Indeed. Lets make it happen. :-) > > It is impossible to convert netgraph to be a pfil, since netgraph isn't > just a function call. It doesn't return processed packet immediately. That's why I added the pfil cookies. You can re-inject a packet after a particular hook after deferred processing. > The carp(4) isn't a layer 2 protocol, but is IP protocol, so I > don't understand how can it be converted to a pfil hook. Obviously not everything can be a layer 2 pfil hook. Where it can, we should at least investigate it to limit the number of special cases in the path. A potential issue is the cpu pinning of the pfil rmlock. We'll have to see whether this is an immediate problem, and if yes, what we can do about it. -- Andre