From owner-freebsd-arch@FreeBSD.ORG  Thu Jun 17 20:38:16 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0A7A106564A
	for <arch@FreeBSD.org>; Thu, 17 Jun 2010 20:38:16 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 64FD58FC08
	for <arch@FreeBSD.org>; Thu, 17 Jun 2010 20:38:16 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o5HKXUWC073455
	for <arch@freebsd.org>; Thu, 17 Jun 2010 14:33:30 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 17 Jun 2010 14:33:34 -0600 (MDT)
Message-Id: <20100617.143334.584432776655157077.imp@bsdimp.com>
To: arch@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Time to stop stripping binaries?
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jun 2010 20:38:16 -0000

Greetings,

Now that disks are big, can we stop stripping binaries by default?

I've worked up a patch that lets you set WITH_BINARY_SYMBOLS or
WITHOUT_BINARY_SYMBOLS as you see fit.  We should commit it regardless
of the outcome of this discussion (well, defaulting to yes or no
depending on the outcome).

Why symbols: it makes core dumps easier to debug.
Why no symbols: makes the system footprint bigger.

Since there's good arguments both ways, I thought I'd make this a
knob.

Comments?

Warner

Index: bsd.own.mk
===================================================================
--- bsd.own.mk	(revision 209268)
+++ bsd.own.mk	(working copy)
@@ -303,6 +303,7 @@
     ATM \
     AUDIT \
     AUTHPF \
+    BINARY_SYMBOLS \
     BIND \
     BIND_DNSSEC \
     BIND_ETC \
Index: bsd.lib.mk
===================================================================
--- bsd.lib.mk	(revision 209268)
+++ bsd.lib.mk	(working copy)
@@ -46,7 +46,7 @@
 .endif
 .endif
 
-.if !defined(DEBUG_FLAGS)
+.if !defined(DEBUG_FLAGS) || ${MK_BINARY_SYMBOLS} == "no"
 STRIP?=	-s
 .endif
 
Index: bsd.prog.mk
===================================================================
--- bsd.prog.mk	(revision 209268)
+++ bsd.prog.mk	(working copy)
@@ -33,7 +33,7 @@
 CFLAGS+=${CRUNCH_CFLAGS}
 .endif
 
-.if !defined(DEBUG_FLAGS)
+.if !defined(DEBUG_FLAGS) || ${MK_BINARY_SYMBOLS} == "no"
 STRIP?=	-s
 .endif