From owner-svn-src-all@FreeBSD.ORG Tue Jun 3 05:01:01 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD912811; Tue, 3 Jun 2014 05:01:01 +0000 (UTC) Received: from mail-qa0-x236.google.com (mail-qa0-x236.google.com [IPv6:2607:f8b0:400d:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A0752B29; Tue, 3 Jun 2014 05:01:01 +0000 (UTC) Received: by mail-qa0-f54.google.com with SMTP id j15so4183086qaq.27 for ; Mon, 02 Jun 2014 22:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Hfw7CLShEALeMP9NbOJGcOWcO7QniA56wbG5oVTJ4YE=; b=XCTDtXaauWgqeJRUEPprzEn5BvbEJf5sgNfT4l6daIY9VzX0Z1FnIViVzKT5vgzBog X6CqGks6mYJpfGcgXjP85WYRzDNPSd7hz5s06ueYwN8ikEX2LYcD40TKd/uSQ5llHuVf jiARS/ZVpKeiRv2UO8eyCBhIVti+cu8x+azzI4AURahJN3AN+Oj1IPAk0MGfY5ksFPcB c/J9GP/+pdWVCPYZocoGkVavD0rJC3965PnGkNLgUAW8EzakHCJpSGo/8kKFcoCdehsE U087wMLkJYMayCZxmlAc13W1kbmwnjlSak7cfxO/o5UZq3uNNivFF2uSk0nqtv8iXF/e eX9w== MIME-Version: 1.0 X-Received: by 10.224.135.66 with SMTP id m2mr58338164qat.55.1401771660439; Mon, 02 Jun 2014 22:01:00 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.43.134 with HTTP; Mon, 2 Jun 2014 22:01:00 -0700 (PDT) In-Reply-To: <20140603012939.GA2998@michelle.cdnetworks.com> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <20140603012939.GA2998@michelle.cdnetworks.com> Date: Mon, 2 Jun 2014 22:01:00 -0700 X-Google-Sender-Auth: PL47hhwgoWMTS5bSb6cDwTDssYc Message-ID: Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net From: Adrian Chadd To: Yong-Hyeon Pyun Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" , Marcel Moolenaar X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 05:01:02 -0000 On 2 June 2014 18:29, Yonghyeon PYUN wrote: > On Mon, Jun 02, 2014 at 11:42:10AM -0700, Marcel Moolenaar wrote: >> >> On Jun 2, 2014, at 11:27 AM, Adrian Chadd wrote: >> >> > .. and actually, bikeshedding for a moment, would we be able to move a >> > lot of these accessor methods over to inlines? Would that break the >> > Juniper way of doing things? >> >> That would definitely break Juniper as it doesn't give a stable >> ABI. >> >> I've suggested an approach that allows for both, but it was deemed >> unnecessary. The argument being that the function call overhead is >> negligible. >> >> We can always revisit that decision if needed... >> > > The function call overheads shall show measurable differences on > slow boxes. This change adds several function calls in driver's > fast path(interrupt handler, packet statistics, checksum > offloading checking and etc) and these functions would be called > on every TX/RX packet. > It would be great if there is a way to minimize function call > overheads in fast path. I wonder if in the short term we should just use inlines for now, at least so the methodization can get done without hurting people on ARM/MIPS. ARM/MIPS people (me included) - let's see if we can generate some number? -a