From owner-freebsd-bugs@FreeBSD.ORG Sun Feb 22 15:40:48 2015 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 763F943C for ; Sun, 22 Feb 2015 15:40:48 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C9A592 for ; Sun, 22 Feb 2015 15:40:48 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1MFelct022556 for ; Sun, 22 Feb 2015 15:40:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 197923] [patch] [sched] Fix comment in sched_balance_pair and move load check ahead of lock Date: Sun, 22 Feb 2015 15:40:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: harrison.grundy@astrodoggroup.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform bug_file_loc op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2015 15:40:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197923 Bug ID: 197923 Summary: [patch] [sched] Fix comment in sched_balance_pair and move load check ahead of lock Product: Base System Version: 11.0-CURRENT Hardware: Any URL: https://github.com/AstrodogInc/freebsd_schedulers/blob /master/ule_patches/fix_sched_balance_pair_comment_and _move_lock.diff OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: harrison.grundy@astrodoggroup.com Created attachment 153318 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153318&action=edit Fix comment in sched_balance_pair and move load check ahead of lock Comment in sched_balance_pair suggests that it may balance more than one thread at a time, while tdq_move operates on only one thread. Also move load check to before tdq_lock_pair, as the tdq lock is not required to check load. -- You are receiving this mail because: You are the assignee for the bug.