From owner-svn-src-head@freebsd.org Mon Jan 25 14:59:30 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51374A45235 for ; Mon, 25 Jan 2016 14:59:30 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6C58B98 for ; Mon, 25 Jan 2016 14:59:29 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lf0-x22b.google.com with SMTP id 17so86184516lfz.1 for ; Mon, 25 Jan 2016 06:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=I+7ZeBLKMsPBynLFxtulq5YQ9oWedNd8APiHeBDic0E=; b=dxHU4ULMmrys99GocOQvJHxtONuAyVjET8fLO1CPVLgdV8rrCkGd9jPcNt4IstxSZJ hkQBib4Oult5sW2j9VHWoYS0azq/pKzd2kFH6Rqs4mRyp5kCMb9DleUwCdqXKLsJa7HE btO5dWTKpOF7o6NNHbDCdEhl0ZDJa9ZxbbJ7Rfa4k5qxVpRlB83DZS4EWUBNXieak4i/ qldsdYpOtsF80LRrgkKFZuFqyS696vf5ZKXhiRqHs79MtaYqiLkL+rixvQ6pzGRJYwlV DDRWttoo9r0EpMwi45qLUEtWKtBxVh4UCavsp3udVUjcwwLeK1aygFhHhqAVxfldUGt5 8DnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=I+7ZeBLKMsPBynLFxtulq5YQ9oWedNd8APiHeBDic0E=; b=D6WhqFD9TIC+mmYnOevW0Ltnr/o1yN+nnpgq+E3PcwrQgHvay2bRw/L2eLENTy8Ebk RcPobgwceHNfN/dvUsbNjo91AiWvt5NqNUk4OJmyW/wsBdfTuTBmm5SO/2Ce+7d5cpqj D5/aBZ+FBUu9jv+axlVcsXKSmwi14qXfBgxmx3/QL8AzNUACkOIGz6QO132kgsiMYPym 3TQ2x4WX1Rq7AB3Rzqmz46OiGt7v0Wn5bHc4f+DjUcbxNENhq3VlOl/AyVGHJGCWpWXQ Ah5OnL1NEuFn1m/1j24i2CNw5z/2rcHABzt8qSCY9WJciKlDJ5gfmqIb8iZoDDLs8wOv Cx3Q== X-Gm-Message-State: AG10YOTN7xh5hcxAfkgHMur4A0KrVOkbSAuA3OlRe66af2ZIwguHmQhDEvlqjXePpPORQJ/pxyG1poJV+F6E7A== X-Received: by 10.25.205.81 with SMTP id d78mr6948928lfg.15.1453733967755; Mon, 25 Jan 2016 06:59:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.24.93 with HTTP; Mon, 25 Jan 2016 06:59:08 -0800 (PST) In-Reply-To: <201601251442.u0PEgi2t025216@repo.freebsd.org> References: <201601251442.u0PEgi2t025216@repo.freebsd.org> From: Zbigniew Bodek Date: Mon, 25 Jan 2016 15:59:08 +0100 Message-ID: Subject: Re: svn commit: r294729 - head/sys/dev/ofw To: Zbigniew Bodek Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2016 14:59:30 -0000 I forgot Differential Revision: https://reviews.freebsd.org/D5065 2016-01-25 15:42 GMT+01:00 Zbigniew Bodek : > Author: zbb > Date: Mon Jan 25 14:42:44 2016 > New Revision: 294729 > URL: https://svnweb.freebsd.org/changeset/base/294729 > > Log: > Do not destroy input buffer of the OF_getencprop() function on error > > Currently when the OF_getprop() function returns with error, > the caller (OF_getencprop()) still changes the buffer endiannes. > This may destroy the default value passed in the input buffer if > used on a Little Endian platform. > > Reviewed by: mmel > Submitted by: Zbigniew Bodek > Obtained from: Semihalf > Sponsored by: Cavium > > Modified: > head/sys/dev/ofw/openfirm.c > > Modified: head/sys/dev/ofw/openfirm.c > > ============================================================================== > --- head/sys/dev/ofw/openfirm.c Mon Jan 25 14:13:28 2016 (r294728) > +++ head/sys/dev/ofw/openfirm.c Mon Jan 25 14:42:44 2016 (r294729) > @@ -394,6 +394,9 @@ OF_getencprop(phandle_t node, const char > KASSERT(len % 4 == 0, ("Need a multiple of 4 bytes")); > > retval = OF_getprop(node, propname, buf, len); > + if (retval <= 0) > + return (retval); > + > for (i = 0; i < len/4; i++) > buf[i] = be32toh(buf[i]); > > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >