From owner-svn-src-all@FreeBSD.ORG Tue Jun 3 23:45:19 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F04D839E; Tue, 3 Jun 2014 23:45:18 +0000 (UTC) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 28908283D; Tue, 3 Jun 2014 23:45:18 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 5586125D3A85; Tue, 3 Jun 2014 23:45:14 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 5BCE8C22BD1; Tue, 3 Jun 2014 23:45:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id cbboa208AmIW; Tue, 3 Jun 2014 23:45:12 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:c134:ee3c:ac56:1105] (unknown [IPv6:fde9:577b:c1a9:4410:c134:ee3c:ac56:1105]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A5396C22B96; Tue, 3 Jun 2014 23:45:10 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: "Bjoern A. Zeeb" In-Reply-To: <201406032106.s53L63oR085624@svn.freebsd.org> Date: Tue, 3 Jun 2014 23:45:00 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201406032106.s53L63oR085624@svn.freebsd.org> To: Alexander Motin X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 23:45:19 -0000 On 03 Jun 2014, at 21:06 , Alexander Motin wrote: > Author: mav > Date: Tue Jun 3 21:06:03 2014 > New Revision: 267029 > URL: http://svnweb.freebsd.org/changeset/base/267029 >=20 > Log: > Replace gethrtime() with cpu_ticks(), as source of random for the = taskqueue > selection. gethrtime() in our port updated with HZ rate, so unusable = for > this specific purpose, completely draining benefit of multiple = taskqueues. >=20 > MFC after: 2 weeks >=20 I am seeing this now for all buildworld targets: = /storage/head/obj//arm.armeb/scratch/tmp/bz/head.svn/tmp/usr/lib/libzpool.= so: undefined reference to `cpu_ticks' > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun = 3 21:02:19 2014 (r267028) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun = 3 21:06:03 2014 (r267029) > @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t > if (tqs->stqs_count =3D=3D 1) { > tq =3D tqs->stqs_taskq[0]; > } else { > - tq =3D tqs->stqs_taskq[gethrtime() % tqs->stqs_count]; > + tq =3D tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count]; > } >=20 > taskq_dispatch_ent(tq, func, arg, flags, ent); >=20 =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983