From owner-cvs-all@FreeBSD.ORG Tue Jan 2 19:07:37 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D255D16A403 for ; Tue, 2 Jan 2007 19:07:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id 737D413C46A for ; Tue, 2 Jan 2007 19:07:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 24090 invoked by uid 399); 2 Jan 2007 19:07:36 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 2 Jan 2007 19:07:36 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <459AAD78.4060307@FreeBSD.org> Date: Tue, 02 Jan 2007 11:07:36 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: John Baldwin References: <200612302154.kBULsfOi057238@repoman.freebsd.org> <20070102003516.GW78631@wantadilla.lemis.com> <459A9CAE.6030909@FreeBSD.org> <200701021335.17252.jhb@freebsd.org> In-Reply-To: <200701021335.17252.jhb@freebsd.org> X-Enigmail-Version: 0.94.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg 'groggy' Lehey , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/games/fortune/datfiles fortunes fortunes-o.real X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2007 19:07:37 -0000 John Baldwin wrote: > On Tuesday 02 January 2007 12:55, Doug Barton wrote: >> Greg 'groggy' Lehey wrote: >>> On Saturday, 30 December 2006 at 21:54:41 +0000, Doug Barton wrote: >>>> dougb 2006-12-30 21:54:41 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> games/fortune/datfiles fortunes fortunes-o.real >>>> Log: >>>> Add the fortunes from the PR that were not already present. >>>> Delete some duplicates found while double checking the new ones, >>>> and fix a typo. >>>> >>>> These haven't been sorted yet, but will be in a future commit. >>> Why didn't you sort them first? >> Because the rest of the files are not sorted either, and I wanted to >> keep the commits separate. >> >> I have a patch that I'm going to work on getting into the tree today >> that adds a comment to each file about sorting, and then I'll sort the >> files obviously. (All of which was discussed and consensus reached a >> little while ago, I think on -current.) I was going to do it >> yesterday, but family obligations kept me away from the keyboard. > > src/games/fortune/tools/do_sort Yes, the patch I have adds a note about that. > They should already be largely sorted (at least 'fortunes') as they've > been explicitly sorted via do_sort in the past. They are for the most part, yes. But when I added the new fortunes and then sorted the file, it was enough different that I felt it would be better to do it in two stages. Doug -- This .signature sanitized for your protection