From owner-svn-src-all@FreeBSD.ORG  Mon Aug 24 06:22:50 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6E12D106568E
	for <svn-src-all@freebsd.org>; Mon, 24 Aug 2009 06:22:50 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id B8C668FC1C
	for <svn-src-all@freebsd.org>; Mon, 24 Aug 2009 06:22:49 +0000 (UTC)
Received: (qmail invoked by alias); 24 Aug 2009 06:22:48 -0000
Received: from p54A3ECAA.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.236.170]
	by mail.gmx.net (mp035) with SMTP; 24 Aug 2009 08:22:48 +0200
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX1+8r1h79268A/y+QhFq6IyRYJ+99yDHBWZY1WTW1N
	wiQMhHUyIDB/tt
Message-ID: <4A9231B7.9070204@gmx.de>
Date: Mon, 24 Aug 2009 08:22:47 +0200
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.23 (X11/20090823)
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <200908231952.n7NJqlFg070672@svn.freebsd.org>
In-Reply-To: <200908231952.n7NJqlFg070672@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.5
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r196478 - head/etc
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2009 06:22:50 -0000

Doug Barton schrieb:
> Author: dougb
> Date: Sun Aug 23 19:52:47 2009
> New Revision: 196478
> URL: http://svn.freebsd.org/changeset/base/196478
> 
> Log:
>   Prior to the dire warning about values of network_interfaces other than
>   AUTO the biggest mistake users made was leaving lo0 off the list. Since
>   lo0 is effectively mandatory, check for it and add it to the list if
>   it's not there.
> 
> Modified:
>   head/etc/network.subr
> 
> Modified: head/etc/network.subr
> ==============================================================================
> --- head/etc/network.subr	Sun Aug 23 18:28:58 2009	(r196477)
> +++ head/etc/network.subr	Sun Aug 23 19:52:47 2009	(r196478)
> @@ -727,6 +727,13 @@ list_net_interfaces()
>  		;;
>  	*)
>  		_tmplist="${network_interfaces} ${cloned_interfaces}"
> +
> +		# lo0 is effectively mandatory, so help prevent foot-shooting
> +		#
> +		case "$_tmplist" in
> +		lo0*|*lo0|*' lo0 '*)	;;	# This is fine, do nothing

Doesn't this also match malo0?
IMO the test should be lo0|'lo0 '*|*' lo0'|*' lo0 '*.

	Christoph