From owner-freebsd-current Fri Aug 10 1: 2:28 2001 Delivered-To: freebsd-current@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 592B637B403; Fri, 10 Aug 2001 01:02:16 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f7A81pX10234; Fri, 10 Aug 2001 11:01:52 +0300 (EEST) (envelope-from ru) Date: Fri, 10 Aug 2001 11:01:51 +0300 From: Ruslan Ermilov To: Warner Losh Cc: "David O'Brien" , current@FreeBSD.ORG Subject: Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file Message-ID: <20010810110151.B7988@sunbay.com> Mail-Followup-To: Warner Losh , David O'Brien , current@FreeBSD.ORG References: <20010809123057.A2745@sunbay.com> <200108100728.f7A7SV134368@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200108100728.f7A7SV134368@harmony.village.org>; from imp@harmony.village.org on Fri, Aug 10, 2001 at 01:28:31AM -0600 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Aug 10, 2001 at 01:28:31AM -0600, Warner Losh wrote: > In message <20010809123057.A2745@sunbay.com> Ruslan Ermilov writes: > : As you have been warned, revisions 1.19 and 1.20 to file/Makefile > > This looks like it should work. I'm starting a build before I head to > bed with the changes to see if they really do work or not. It is a > little ugly, but not so ugly that I'd object overmuch. > Not uglier than, say, in usr.sbin/sysinstall/Makefile. Imagine that the -C functionality has been moved into its own utility. Then things become much more obvious. And yes, it worked for me last night on a fresh 5.0 `make world' run on a 4.3-STABLE box. > I'd be inclinded to add a small comment to the files Makefile > explaining what build-tools is used for: > > # build-tools for cross compilation and system upgrades > > maybe. Otherwise, someone may accidentally break it in one of the > periodic cleaning sweeps we have. > Nope, the `build-tools' is not for cross compilation and system upgrades. This target builds tools that are needed (only) during the build process (read: buildworld), hence the `build-tools'. As a consequence, they *must* be built in a host environment (libraries, etc.) and for the building platform (not the target platform for the cross-building case). The purpose of the build-tools is already documented in the main src/Makefile.inc1, so if one just "accidentally breaks them", the `buildworld' will start to fail. I am going to commit my patch tomorrow, unless I hear any better ideas of how to fix this. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message