From owner-cvs-ports@FreeBSD.ORG Sun Jul 31 07:47:37 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A05E9106564A; Sun, 31 Jul 2011 07:47:37 +0000 (UTC) (envelope-from support@rtmpd.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id A19E38FC0A; Sun, 31 Jul 2011 07:47:35 +0000 (UTC) Received: by fxe4 with SMTP id 4so4937497fxe.13 for ; Sun, 31 Jul 2011 00:47:34 -0700 (PDT) Received: by 10.223.24.92 with SMTP id u28mr4389056fab.148.1312096862749; Sun, 31 Jul 2011 00:21:02 -0700 (PDT) Received: from [10.0.1.2] ([79.115.160.60]) by mx.google.com with ESMTPS id l22sm2108725fam.33.2011.07.31.00.21.01 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 31 Jul 2011 00:21:02 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1244.3) Content-Type: multipart/signed; boundary="Apple-Mail=_ACC0D98D-EA20-401A-8178-AA950F5B22BF"; protocol="application/pkcs7-signature"; micalg=sha1 From: C++ RTMP Server Support In-Reply-To: <4E3495B0.3070405@FreeBSD.org> Date: Sun, 31 Jul 2011 10:21:01 +0300 Message-Id: References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1244.3) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jin-Sih Lin , cvs-ports@FreeBSD.org, Li-Wen Hsu , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 07:47:37 -0000 --Apple-Mail=_ACC0D98D-EA20-401A-8178-AA950F5B22BF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 But I set it up. I pick it up from rc.conf settings or default it to = "/var/run/${name}.pid". The big difference is that now the pid file is generated by crtmpserver = (the binary). Now it has --pid parameter. Before, it was generated by = the script. If you feel that we should keep the old approach (generate the pid from = the script, not from the binary), is totally fine with me Best regards, Andrei On Jul 31, 2011, at 2:37 AM, Doug Barton wrote: > Is there a reason you're not setting pidfile anymore? While on one = hand > I think allowing users to specify ${name}_pidfile is usually overkill, > the pidfile variable is special in rc.subr. If you're going to allow = the > user to specify the pidfile location the usual way to do that is: >=20 > pidfile=3D"${foo_pidfile:-/var/run/foo.pid}" >=20 > (at some point after load_rc_config). Then use $pidfile throughout the > rest of the script. >=20 >=20 > Doug >=20 >=20 > On 07/30/2011 08:49, Li-Wen Hsu wrote: >> lwhsu 2011-07-30 15:49:07 UTC >>=20 >> FreeBSD ports repository >>=20 >> Modified files: >> net/crtmpserver Makefile distinfo pkg-plist=20 >> net/crtmpserver/files crtmpserver.in=20 >> Log: >> - Update to 0.545 >>=20 >> PR: ports/158886 = http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D158886 >> Submitted by: Jin-Sih Lin >> Approved by: C++ RTMP Server Support (Andrei) = (maintainer) >>=20 >> Revision Changes Path >> 1.4 +10 -11 ports/net/crtmpserver/Makefile >> 1.2 +2 -2 ports/net/crtmpserver/distinfo >> 1.3 +7 -13 ports/net/crtmpserver/files/crtmpserver.in >> 1.2 +2 -21 ports/net/crtmpserver/pkg-plist >>=20 >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/Makefile.diff?= &r1=3D1.3&r2=3D1.4&f=3Dh >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/distinfo.diff?= &r1=3D1.1&r2=3D1.2&f=3Dh >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/files/crtmpser= ver.in.diff?&r1=3D1.2&r2=3D1.3&f=3Dh >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/pkg-plist.diff= ?&r1=3D1.1&r2=3D1.2&f=3Dh >>=20 >=20 >=20 >=20 > --=20 >=20 > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go >=20 > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ >=20 ------ C++ RTMP Server Support Email: support@rtmpd.com Web: http://www.rtmpd.com --Apple-Mail=_ACC0D98D-EA20-401A-8178-AA950F5B22BF--