From owner-freebsd-bugs@FreeBSD.ORG  Mon Mar 10 12:00:01 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EF6E4C41
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 10 Mar 2014 12:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id DD780E53
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 10 Mar 2014 12:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2AC01Gk061536
 for <freebsd-bugs@freefall.freebsd.org>; Mon, 10 Mar 2014 12:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2AC01nt061535;
 Mon, 10 Mar 2014 12:00:01 GMT (envelope-from gnats)
Date: Mon, 10 Mar 2014 12:00:01 GMT
Message-Id: <201403101200.s2AC01nt061535@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Petr Lampa <lampa@fit.vutbr.cz>
Subject: Re: bin/187221: fsck_ufs -p segmentation fault with SU+J
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: Petr Lampa <lampa@fit.vutbr.cz>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Mar 2014 12:00:02 -0000

The following reply was made to PR bin/187221; it has been noted by GNATS.

From: Petr Lampa <lampa@fit.vutbr.cz>
To: bug-followup@FreeBSD.org
Cc: mckusick@mckusick.com
Subject: Re: bin/187221: fsck_ufs -p segmentation fault with SU+J
Date: Mon, 10 Mar 2014 12:43:11 +0100

 Simple fix, fsck -p runs without sigsegv now:
 
 --- fsutil.c    2013-07-10 17:04:10.000000000 +0200
 +++ fsutil.c.my 2014-03-10 12:33:55.000000000 +0100
 @@ -414,13 +414,15 @@
         }
         if (numbufs != cnt)
                 errx(EEXIT, "panic: lost %d buffers", numbufs - cnt);
 -       for (cnt = 0; cnt < sblock.fs_ncg; cnt++) {
 -               if (cgbufs[cnt].b_un.b_cg == NULL)
 -                       continue;
 -               flush(fswritefd, &cgbufs[cnt]);
 -               free(cgbufs[cnt].b_un.b_cg);
 +       if (cgbufs) {
 +               for (cnt = 0; cnt < sblock.fs_ncg; cnt++) {
 +                       if (cgbufs[cnt].b_un.b_cg == NULL)
 +                               continue;
 +                       flush(fswritefd, &cgbufs[cnt]);
 +                       free(cgbufs[cnt].b_un.b_cg);
 +               }
 +               free(cgbufs);
         }
 -       free(cgbufs);
         pbp = pdirbp = (struct bufarea *)0;
         if (cursnapshot == 0 && sblock.fs_clean != markclean) {
                 if ((sblock.fs_clean = markclean) != 0) {
 
 Petr Lampa
 
 -- 
 Computer Centre                             E-mail: lampa@fit.vutbr.cz
 Faculty of Information Technology           Web: http://www.fit.vutbr.cz/
 Brno University of Technology               Fax:  +420 54114-1270
 Bozetechova 2, 612 66 Brno, Czech Republic  Phone: +420 54114-1225