From owner-svn-src-all@FreeBSD.ORG Sun Jun 8 18:27:39 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E7EB6AA2; Sun, 8 Jun 2014 18:27:38 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 881942CED; Sun, 8 Jun 2014 18:27:38 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s58IRS1i062468; Sun, 8 Jun 2014 21:27:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s58IRS1i062468 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.8/Submit) id s58IRSsW062467; Sun, 8 Jun 2014 21:27:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 8 Jun 2014 21:27:28 +0300 From: Konstantin Belousov To: Bryan Drewery Subject: Re: svn commit: r267233 - in head: . bin/rmail gnu/usr.bin/binutils/addr2line gnu/usr.bin/binutils/nm gnu/usr.bin/binutils/objcopy gnu/usr.bin/binutils/objdump gnu/usr.bin/binutils/readelf gnu/usr.bin/... Message-ID: <20140608182728.GX3991@kib.kiev.ua> References: <201406081729.s58HTWkc006213@svn.freebsd.org> <74512A27-DD5F-4D43-BFA1-0AC04E0D08B4@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fD6GIi1NIioU6454" Content-Disposition: inline In-Reply-To: <74512A27-DD5F-4D43-BFA1-0AC04E0D08B4@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2014 18:27:39 -0000 --fD6GIi1NIioU6454 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 08, 2014 at 05:38:49PM +0000, Bjoern A. Zeeb wrote: >=20 > On 08 Jun 2014, at 17:29 , Bryan Drewery wrote: >=20 > > Author: bdrewery > > Date: Sun Jun 8 17:29:31 2014 > > New Revision: 267233 > > URL: http://svnweb.freebsd.org/changeset/base/267233 > >=20 > > Log: > > In preparation for ASLR [1] support add WITH_PIE to support building w= ith -fPIE. > >=20 > > This is currently an opt-in build flag. Once ASLR support is ready and= stable > > it should changed to opt-out and be enabled by default along with ASLR. > >=20 > > Each application Makefile uses opt-out to ensure that ASLR will be ena= bled by > > default in new directories when the system is compiled with PIE/ASLR. = [2] > >=20 > > Mark known build failures as NO_PIE for now. >=20 > No, no, no, no more NOs! >=20 > I?ll leave it to others who understand the current build system in days w= hen it?s not broken to fix this entire splattering across all these Makefil= es; we really need a better way for this. I have no words to express my dissatisfaction with this commit. If change to the build of _some_ usermode binaries require patching of loader', csu and rtld Makefiles, obviously it is done wrong. Why almost half of the binaries require opt-out ? =20 PLEASE REVERT THIS. --fD6GIi1NIioU6454 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTlKsQAAoJEJDCuSvBvK1B710QAJCZI3sZ8uERnmTGoxlWrAzT 6Ln1ZR98SZnSGQcqWgy4kB4PUGJOCZl2xo6XyoZ9eCz8aaP5UuKV5T/pAvzs0f16 KADTdPQKsRgne8yYCGqhEkseXxySZI7So6CY1Hb9rS+8lWiySYL3q3MPy0Cb0C+k j6J8+qxGFzh/US8iZS4eCuzFwgD78xE2SLWKAdvGJhzhrOym0XrRw7VgFLFVzJ7v WESw44zqdzdpMRsSaOxxC9WgaooUvhXggTQK5elM+SwXcNBd6m2nziOPn+r7FXBI CEigccIxamn7cKWV/MLSs6s9XS6ho7oiLH+kb4Iq10RhdySZ8plESos/FJZpWTXQ 2LhFQYZQh0S84XiDZ52YRjeVxn0LbL1OzS8IYFHVUHBCRcFiDkod0fGmtWaAyL7v 6/TIqEHzfGIEKj2Qz0B4BLrVuox2b4P4MbfPCFWjgAzXpH1zUjiC7a1WloRhn5Vv H0Ji/oGuRgcSqtPhDCZLYWMfMyY1+mKfcEHCyJvfpo/ilP6UG9CqBOFPDFbRz3uH ynM2q0BPtsaqLRBjdBb3XinOIkwLsQFFc9y6H4Rj3Z6v9pqXT+QjsV1qLfSPFHgZ oaquZo6/wif75scIEMUfxKImSzxBt3XsekaYDOOpc8ZI/wQqKNIupBRIdWaLSTL5 UAimP4JBWajZBOO60kPW =pzhD -----END PGP SIGNATURE----- --fD6GIi1NIioU6454--